fix paragraph text indentation

Author: artem-harbour

packages/super-editor/src/core/super-converter/exporter.js

@@ -167,7 +167,7 @@ function generateParagraphProperties(node) {
   const { styleId } = attrs;
   if (styleId) pPrElements.push({ name: 'w:pStyle', attributes: { 'w:val': styleId } });
 
-  const { spacing, indent, textAlign } = attrs;
+  const { spacing, indent, textAlign, textIndent } = attrs;
   if (spacing) {
     const { lineSpaceBefore, lineSpaceAfter, line, lineRule } = spacing;
 
@@ -185,19 +185,31 @@ function generateParagraphProperties(node) {
     };
     pPrElements.push(spacingElement);
   }
-
+  
   if (indent) {
     const { left, right, firstLine } = indent;
     const attributes = {};
     if (left || left === 0) attributes['w:left'] = pixelsToTwips(left);
     if (right || right === 0) attributes['w:right'] = pixelsToTwips(right);
     if (firstLine || firstLine === 0) attributes['w:firstLine'] = pixelsToTwips(firstLine);
 
+    if (textIndent && !attributes['w:left']) {
+      attributes['w:left'] = inchesToTwips(textIndent);
+    }
+    
     const indentElement = {
       name: 'w:ind',
       attributes,
     };
     pPrElements.push(indentElement);
+  } else if (textIndent) {
+    const indentElement = {
+      name: 'w:ind',
+      attributes: { 
+        'w:left': inchesToTwips(textIndent), 
+      },
+    };
+    pPrElements.push(indentElement);
   }
 
   if (textAlign) {

packages/super-editor/src/core/super-converter/v2/importer/markImporter.js

@@ -167,7 +167,7 @@ function getFontFamilyValue(attributes, docx) {
 
 function getIndentValue(attributes) {
   let value = attributes['w:left'];
-  if (!value) value = attributes['w:firstLine'];
+  if (!value) return null;
   return `${twipsToInches(value)}in`;
 }
 

packages/super-editor/src/core/super-converter/v2/importer/paragraphNodeImporter.js

@@ -64,8 +64,11 @@ export const handleParagraphNode = (params) => {
       if (firstLine) schemaNode.attrs['indent'].firstLine = twipsToPixels(firstLine);
     }
 
-    const textIndentVal = left || firstLine || 0;
-    schemaNode.attrs['textIndent'] = `${twipsToInches(textIndentVal)}in`;
+    const textIndentValue = left || 0;
+
+    if (textIndentValue) {
+      schemaNode.attrs['textIndent'] = `${twipsToInches(textIndentValue)}in`;
+    }    
   }
 
   const justify = pPr?.elements?.find((el) => el.name === 'w:jc');

packages/super-editor/src/extensions/text-indent/text-indent.js

@@ -1,13 +1,6 @@
 import { Extension } from '@core/index.js';
 import { parseSizeUnit } from '@core/utilities/index.js';
 
-/**
- * Do we need a unit conversion system?
- *
- * For reference.
- * https://remirror.vercel.app/?path=/story/extensions-nodeformatting--basic
- * https://github.com/remirror/remirror/tree/HEAD/packages/remirror__extension-node-formatting
- */
 export const TextIndent = Extension.create({
   name: 'textIndent',
 
@@ -32,7 +25,7 @@ export const TextIndent = Extension.create({
             renderDOM: (attrs) => {
               if (!attrs.textIndent) return {};
               let [value, unit] = parseSizeUnit(attrs.textIndent);
-              if (Number.isNaN(value)) return {};
+              if (Number.isNaN(value) || !value) return {};
               unit = unit ? unit : this.options.defaults.unit;
               return { style: `margin-left: ${value}${unit}` };
             },