Commit 5247889
committed
docs(byo-ui): correct toolbar ids and comment scrollTo scope
Two factual fixes flagged in PR #3034 review:
- toolbar-and-commands.mdx: the built-in command id table listed
several ids that aren't on PublicToolbarItemId. strike →
strikethrough, color → text-color, highlight → highlight-color,
and the entire 'Block' row (heading-1/-2/-3, paragraph) is dropped
because no block-level commands exist on this surface today.
Replaced the table with the actual id set grouped by domain.
- comments.mdx: the trade-off note claimed ui.comments.scrollTo is
story-aware. CommentAddress is body-scoped in the contract — only
TrackedChangeAddress carries a story field — so the call doesn't
navigate to header/footer/note comments. Replaced with an honest
description and pointer to ui.viewport.scrollIntoView for non-body
cases.1 parent 79c0cb2 commit 5247889
2 files changed
Lines changed: 10 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
140 | 140 | | |
141 | 141 | | |
142 | 142 | | |
143 | | - | |
| 143 | + | |
144 | 144 | | |
145 | 145 | | |
146 | 146 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
107 | 107 | | |
108 | 108 | | |
109 | 109 | | |
110 | | - | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
111 | 113 | | |
| 114 | + | |
112 | 115 | | |
113 | | - | |
114 | | - | |
115 | | - | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
116 | 120 | | |
117 | | - | |
| 121 | + | |
118 | 122 | | |
119 | 123 | | |
120 | 124 | | |
| |||
0 commit comments