fix: address PR review feedback for TIFF support

- Use mimeTypeForExt mapping for .tif data URIs (image/tiff not image/tif)
- Remove unused size arg from convertTiffToPng call
- Add happy-path test asserting valid TIFF produces PNG data URI

Author: gpardhivvarma

packages/super-editor/src/core/DocxZipper.js

@@ -64,8 +64,10 @@ class DocxZipper {
           const extension = this.getFileExtension(name)?.toLowerCase();
           // Only build data URIs for images; keep raw base64 for other binaries (e.g., xlsx)
           const imageTypes = new Set(['png', 'jpg', 'jpeg', 'gif', 'bmp', 'tiff', 'tif', 'emf', 'wmf', 'svg', 'webp']);
+          const mimeTypeForExt = { tif: 'tiff' };
           if (imageTypes.has(extension)) {
-            this.mediaFiles[name] = `data:image/${extension};base64,${fileBase64}`;
+            const mimeSubtype = mimeTypeForExt[extension] || extension;
+            this.mediaFiles[name] = `data:image/${mimeSubtype};base64,${fileBase64}`;
             const blob = await zipEntry.async('blob');
             const fileObj = new File([blob], name, { type: blob.type });
             const imageUrl = URL.createObjectURL(fileObj);

packages/super-editor/src/core/super-converter/v3/handlers/wp/helpers/encode-image-node-helpers.js

@@ -403,7 +403,7 @@ export function handleImageNode(node, params, isAnchor) {
       if (converter?.domEnvironment) {
         setTiffDomEnvironment(converter.domEnvironment);
       }
-      const conversionResult = convertTiffToPng(mediaData, size);
+      const conversionResult = convertTiffToPng(mediaData);
       if (conversionResult?.dataUri) {
         finalSrc = conversionResult.dataUri;
         finalExtension = conversionResult.format || 'png';

packages/super-editor/src/core/super-converter/v3/handlers/wp/helpers/tiff-converter.test.js

@@ -60,6 +60,37 @@ describe('tiff-converter', () => {
       expect(result).toBeNull();
     });
 
+    it('returns a PNG data URI for valid TIFF input', () => {
+      const fakeRgba = new Uint8Array(2 * 2 * 4); // 2x2 image, RGBA
+      vi.doMock('utif2', () => ({
+        decode: () => [{ t256: [2], t257: [2] }],
+        decodeImage: (_buf, ifd) => {
+          ifd.width = 2;
+          ifd.height = 2;
+        },
+        toRGBA8: () => fakeRgba,
+      }));
+
+      const mockCanvas = {
+        width: 0,
+        height: 0,
+        getContext: () => ({
+          createImageData: (w, h) => ({ data: new Uint8Array(w * h * 4), width: w, height: h }),
+          putImageData: () => {},
+        }),
+        toDataURL: () => 'data:image/png;base64,iVBORw0KGgo=',
+      };
+      const spy = vi.spyOn(document, 'createElement').mockReturnValue(mockCanvas);
+
+      return import('./tiff-converter.js?happy').then(({ convertTiffToPng: fn }) => {
+        const result = fn(new Uint8Array([0x49, 0x49, 0x2a, 0x00]));
+        expect(result).toEqual({ dataUri: 'data:image/png;base64,iVBORw0KGgo=', format: 'png' });
+
+        spy.mockRestore();
+        vi.doUnmock('utif2');
+      });
+    });
+
     it('returns null for TIFF with dimensions exceeding pixel limit', () => {
       // Mock utif2 to return oversized dimensions via raw IFD tags
       // (t256=ImageWidth, t257=ImageLength — 100k × 10k = 1 billion pixels)