fix(document-api): inherit converter header refs

Author: luccas-harbour

packages/super-editor/src/editors/v1/document-api-adapters/helpers/header-footer-refs-mutation.test.ts

@@ -2,7 +2,11 @@ import { describe, expect, it } from 'vitest';
 import { resolveEffectiveRef } from './header-footer-refs-mutation.js';
 import type { SectionProjection } from './sections-resolver.js';
 
-function projection(sectionIndex: number, refs: SectionProjection['range']['headerRefs']): SectionProjection {
+function projection(
+  sectionIndex: number,
+  refs: SectionProjection['range']['headerRefs'],
+  domainRefs?: SectionProjection['domain']['headerRefs'],
+): SectionProjection {
   return {
     sectionId: `section-${sectionIndex}`,
     address: { kind: 'section', sectionId: `section-${sectionIndex}` },
@@ -11,7 +15,9 @@ function projection(sectionIndex: number, refs: SectionProjection['range']['head
       headerRefs: refs,
     } as SectionProjection['range'],
     target: { kind: 'body' },
-    domain: {},
+    domain: {
+      ...(domainRefs && { headerRefs: domainRefs }),
+    },
   };
 }
 
@@ -38,6 +44,16 @@ describe('resolveEffectiveRef', () => {
     });
   });
 
+  it('inherits converter-preserved refs exposed through section domain metadata', () => {
+    const sections = [projection(0, undefined, { default: 'h0-domain-default' }), projection(1, undefined)];
+
+    expect(resolveEffectiveRef(sections, 1, 'header', 'default')).toMatchObject({
+      refId: 'h0-domain-default',
+      resolvedFromSection: { kind: 'section', sectionId: 'section-0' },
+      resolvedVariant: 'default',
+    });
+  });
+
   it('returns null when resolving before the first section', () => {
     const sections = [projection(0, { default: 'h0-default' })];
 

packages/super-editor/src/editors/v1/document-api-adapters/helpers/header-footer-refs-mutation.ts

@@ -19,6 +19,8 @@ import {
   type ConverterWithHeaderFooterParts,
 } from './header-footer-parts.js';
 
+type HeaderFooterRefs = Partial<Record<HeaderFooterVariant, string | null>>;
+
 // ---------------------------------------------------------------------------
 // Shared resolver
 // ---------------------------------------------------------------------------
@@ -34,12 +36,17 @@ export function resolveEffectiveRef(
   kind: HeaderFooterKind,
   variant: HeaderFooterVariant,
 ): { refId: string; resolvedFromSection: SectionAddress; resolvedVariant: HeaderFooterVariant } | null {
+  const refsFor = (section: SectionProjection, refKind: HeaderFooterKind): HeaderFooterRefs | undefined =>
+    refKind === 'header'
+      ? ((section.range.headerRefs ?? section.domain.headerRefs) as HeaderFooterRefs | undefined)
+      : ((section.range.footerRefs ?? section.domain.footerRefs) as HeaderFooterRefs | undefined);
+
   const resolved = resolveEffectiveHeaderFooterRef({
     sections: sections.map((section) => ({
       sectionIndex: section.range.sectionIndex,
       titlePg: section.range.titlePg,
-      headerRefs: section.range.headerRefs,
-      footerRefs: section.range.footerRefs,
+      headerRefs: refsFor(section, 'header'),
+      footerRefs: refsFor(section, 'footer'),
     })),
     sectionIndex: startSectionIndex - 1,
     kind,