chore: lint

Author: johanneswilm

packages/super-editor/src/assets/styles/elements/prosemirror.css

@@ -148,8 +148,8 @@ img.ProseMirror-separator {
   margin-bottom: 1.5px;
 }
 
-/*
-Tables
+/* 
+Tables 
 https://github.com/ProseMirror/prosemirror-tables/blob/master/style/tables.css
 https://github.com/ProseMirror/prosemirror-tables/blob/master/demo/index.html
 */
@@ -166,8 +166,8 @@ https://github.com/ProseMirror/prosemirror-tables/blob/master/demo/index.html
   scrollbar-width: thin;
   overflow: hidden;
 
-  /*
-  The border width does not need to be multiplied by two,
+  /* 
+  The border width does not need to be multiplied by two, 
   for tables it works differently. */
   width: calc(100% + (var(--table-border-width) + var(--offset)));
 }
@@ -292,25 +292,19 @@ https://github.com/ProseMirror/prosemirror-tables/blob/master/demo/index.html
 /* Collaboration cursors - end */
 
 /* Image placeholder */
-.ProseMirror placeholder,
-.ProseMirror img.placeholder {
+.ProseMirror placeholder {
   display: inline;
   border: 1px solid #ccc;
   color: #ccc;
 }
 
-.ProseMirror placeholder:after,
-.ProseMirror img.placeholder:after {
+.ProseMirror placeholder:after {
   content: '☁';
   font-size: 200%;
   line-height: 0.1;
   font-weight: bold;
 }
 
-.ProseMirror placeholder img {
-  display: none !important;
-}
-
 /* Gapcursor */
 .ProseMirror-gapcursor {
   display: none;

packages/super-editor/src/components/toolbar/super-toolbar.js

@@ -372,7 +372,6 @@ export class SuperToolbar extends EventEmitter {
       }
 
       const { size, file } = await checkAndProcessImage({
-        view: this.activeEditor.view,
         file: result.file,
         getMaxContentSize: () => this.activeEditor.getMaxContentSize(),
       });

packages/super-editor/src/core/super-converter/exporter.js

@@ -4,7 +4,6 @@ import { EditorState } from 'prosemirror-state';
 import { SuperConverter } from './SuperConverter.js';
 import {
   emuToPixels,
-  getTextIndentExportValue,
   inchesToTwips,
   linesToTwips,
   pixelsToEightPoints,
@@ -74,7 +73,6 @@ export function exportSchemaToJson(params) {
   const router = {
     doc: translateDocumentNode,
     body: translateBodyNode,
-    heading: translateHeadingNode,
     paragraph: translateParagraphNode,
     text: translateTextNode,
     bulletList: translateList,
@@ -170,30 +168,6 @@ const generateDefaultHeaderFooter = (type, id) => {
   };
 };
 
-/**
- * Translate a heading node to a paragraph with Word heading style
- *
- * @param {ExportParams} params The parameters object containing the heading node
- * @returns {XmlReadyNode} JSON of the XML-ready paragraph node with heading style
- */
-function translateHeadingNode(params) {
-  const { node } = params;
-  const { level = 1, ...otherAttrs } = node.attrs;
-
-  // Convert heading to paragraph with appropriate Word heading style
-  const paragraphNode = {
-    type: 'paragraph',
-    content: node.content,
-    attrs: {
-      ...otherAttrs,
-      styleId: `Heading${level}`, // Maps to Heading1, Heading2, etc. in Word
-    },
-  };
-
-  // Use existing paragraph translator with the modified node
-  return translateParagraphNode({ ...params, node: paragraphNode });
-}
-
 /**
  * Translate a paragraph node
  *
@@ -306,7 +280,7 @@ function generateParagraphProperties(node) {
     if (hanging || hanging === 0) attributes['w:hanging'] = pixelsToTwips(hanging);
 
     if (textIndent && !attributes['w:left']) {
-      attributes['w:left'] = getTextIndentExportValue(textIndent);
+      attributes['w:left'] = inchesToTwips(textIndent);
     }
 
     const indentElement = {
@@ -318,7 +292,7 @@ function generateParagraphProperties(node) {
     const indentElement = {
       name: 'w:ind',
       attributes: {
-        'w:left': getTextIndentExportValue(textIndent),
+        'w:left': inchesToTwips(textIndent),
       },
     };
     pPrElements.push(indentElement);
@@ -970,13 +944,7 @@ function translateLineBreak(params) {
   }
 
   return {
-    name: 'w:r',
-    elements: [
-      {
-        name: 'w:br',
-        attributes,
-      },
-    ],
+    name: 'w:br',
     attributes,
   };
 }
@@ -1546,7 +1514,6 @@ function getScaledSize(originalWidth, originalHeight, maxWidth, maxHeight) {
 }
 
 function translateImageNode(params, imageSize) {
-  console.log('translateImageNode', { params, imageSize });
   const {
     node: { attrs = {} },
     tableCell,
@@ -1998,12 +1965,7 @@ function prepareUrlAnnotation(params) {
  * @param {String} annotationType
  * @returns {Function} handler for provided annotation type
  */
-function getTranslationByAnnotationType(annotationType, annotationFieldType) {
-  // invalid annotation
-  if (annotationType === 'text' && annotationFieldType === 'FILEUPLOADER') {
-    return null;
-  }
-
+function getTranslationByAnnotationType(annotationType) {
   const imageEmuSize = {
     w: 4286250,
     h: 4286250,
@@ -2049,7 +2011,7 @@ const translateFieldAttrsToMarks = (attrs = {}) => {
 function translateFieldAnnotation(params) {
   const { node, isFinalDoc, fieldsHighlightColor } = params;
   const { attrs = {} } = node;
-  const annotationHandler = getTranslationByAnnotationType(attrs.type, attrs.fieldType);
+  const annotationHandler = getTranslationByAnnotationType(attrs.type);
   if (!annotationHandler) return {};
 
   let processedNode;
@@ -2321,14 +2283,8 @@ export class DocxExporter {
       if (name === 'w:instrText') {
         tags.push(elements[0].text);
       } else if (name === 'w:t' || name === 'w:delText' || name === 'wp:posOffset') {
-        try {
-          // test for valid string
-          let text = String(elements[0].text);
-          text = this.#replaceSpecialCharacters(text);
-          tags.push(text);
-        } catch (error) {
-          console.error('Text element does not contain valid string:', error);
-        }
+        const text = this.#replaceSpecialCharacters(elements[0].text);
+        tags.push(text);
       } else {
         if (elements) {
           for (let child of elements) {

packages/super-editor/src/extensions/image/imageHelpers/handleUrl.js

@@ -100,7 +100,7 @@ export const validateUrlAccessibility = async (url) => {
       credentials: 'omit',
     });
     return response.ok;
-  } catch (error) {
+  } catch (_error) {
     return false;
   }
 };

packages/super-editor/src/extensions/image/imageHelpers/imageRegistrationPlugin.js

@@ -1,6 +1,6 @@
 import { Plugin, PluginKey } from 'prosemirror-state';
 import { Decoration, DecorationSet } from 'prosemirror-view';
-import { ReplaceStep, ReplaceAroundStep, StepMap } from 'prosemirror-transform';
+import { ReplaceStep, ReplaceAroundStep } from 'prosemirror-transform';
 import { base64ToFile } from './handleBase64';
 import { urlToFile, validateUrlAccessibility } from './handleUrl';
 import { checkAndProcessImage, uploadAndInsertImage } from './startImageUpload';
@@ -87,7 +87,7 @@ export const ImageRegistrationPlugin = ({ editor }) => {
       // Add decorations for the images first at their current positions
       foundImages
         .toSorted((a, b) => a.pos - b.pos)
-        .forEach(({ node, pos, id }) => {
+        .forEach(({ pos, id }) => {
           let deco = Decoration.widget(pos, () => document.createElement('placeholder'), {
             side: -1,
             id,
@@ -187,7 +187,6 @@ const registerImages = async (foundImages, editor, view) => {
     try {
       const process = await checkAndProcessImage({
         getMaxContentSize: () => editor.getMaxContentSize(),
-        view,
         file,
       });
 

packages/super-editor/src/extensions/image/imageHelpers/startImageUpload.js

@@ -13,13 +13,11 @@ const fileTooLarge = (file) => {
   return false;
 };
 
-export const checkAndProcessImage = async ({ getMaxContentSize, view, file }) => {
+export const checkAndProcessImage = async ({ getMaxContentSize, file }) => {
   if (fileTooLarge(file)) {
     return { file: null, size: { width: 0, height: 0 } };
   }
 
-  let width;
-  let height;
   try {
     // Will process the image file in place
     const processedImageResult = await processUploadedImage(file, getMaxContentSize);