Merge pull request #424 from Harbour-Enterprises/nick/har-9353-fix-missing-comments-in-export

edoversb · web-flow · commit 72a698db6710 · 2025-03-25T12:26:25.000-07:00
HAR-9353 - Force generateRandom32BitHex to only positive values
diff --git a/packages/super-editor/src/core/helpers/generateDocxRandomId.js b/packages/super-editor/src/core/helpers/generateDocxRandomId.js
@@ -15,5 +15,6 @@ export function generateDocxRandomId(length = 8) {
 }
 
 export function generateRandom32BitHex() {
-  return Math.floor(Math.random() * 0xFFFFFFFF).toString(16).toUpperCase().padStart(8, '0');
-};
+  const val = Math.floor(Math.random() * 0x7FFFFFFF);
+  return val.toString(16).toUpperCase().padStart(8, '0');
+};

Original file line number	Diff line number	Diff line change
`@@ -15,5 +15,6 @@ export function generateDocxRandomId(length = 8) {`
`15`	`15`	`}`
`16`	`16`
`17`	`17`	`export function generateRandom32BitHex() {`
`18`		`- return Math.floor(Math.random() * 0xFFFFFFFF).toString(16).toUpperCase().padStart(8, '0');`
`19`		`-};`
	`18`	`+ const val = Math.floor(Math.random() * 0x7FFFFFFF);`
	`19`	`+ return val.toString(16).toUpperCase().padStart(8, '0');`
	`20`	`+};`