Skip to content

Commit 74fca9c

Browse files
authored
fix(tables): defaultTableStyle support, cell fixes (#2246)
* fix(tables): defaultTableStyle support, cell fixes * chore: update tests
1 parent 09ebfcb commit 74fca9c

40 files changed

Lines changed: 1670 additions & 1314 deletions

packages/layout-engine/layout-bridge/test/performance.test.ts

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ beforeAll(() => {
2424
const describeIfRealCanvas = usingStub ? describe.skip : describe;
2525

2626
const IS_CI = Boolean(process.env.CI);
27+
const NON_CI_LATENCY_VARIANCE_FACTOR = 1.05;
2728
const LATENCY_TARGETS = IS_CI
2829
? {
2930
// CI environments are slower and more variable; use generous buffers
@@ -37,6 +38,11 @@ const LATENCY_TARGETS = IS_CI
3738
p99: 90,
3839
};
3940
const MIN_HIT_RATE = 0.95;
41+
const latencyBudget = (target: number): number => {
42+
if (IS_CI) return target;
43+
// Full-suite runs can introduce small scheduling variance; keep a tight but non-brittle budget.
44+
return target * NON_CI_LATENCY_VARIANCE_FACTOR;
45+
};
4046

4147
describeIfRealCanvas('incremental pipeline benchmarks', () => {
4248
it('meets latency and cache targets across document sizes', async () => {
@@ -69,9 +75,9 @@ describeIfRealCanvas('incremental pipeline benchmarks', () => {
6975
);
7076
}
7177
expect(result.actualPages).toBe(result.targetPages);
72-
expect(result.latency.p50).toBeLessThanOrEqual(LATENCY_TARGETS.p50);
73-
expect(result.latency.p90).toBeLessThanOrEqual(LATENCY_TARGETS.p90);
74-
expect(result.latency.p99).toBeLessThanOrEqual(LATENCY_TARGETS.p99);
78+
expect(result.latency.p50).toBeLessThanOrEqual(latencyBudget(LATENCY_TARGETS.p50));
79+
expect(result.latency.p90).toBeLessThanOrEqual(latencyBudget(LATENCY_TARGETS.p90));
80+
expect(result.latency.p99).toBeLessThanOrEqual(latencyBudget(LATENCY_TARGETS.p99));
7581
if (result.targetPages >= 10) {
7682
expect(result.cache.hitRate).toBeGreaterThanOrEqual(MIN_HIT_RATE);
7783
} else {

packages/layout-engine/pm-adapter/__mocks__/@converter/tbl-translator.d.ts

Lines changed: 0 additions & 9 deletions
This file was deleted.

packages/layout-engine/pm-adapter/__mocks__/@converter/tbl-translator.js

Lines changed: 0 additions & 21 deletions
This file was deleted.

packages/layout-engine/pm-adapter/src/converter-context.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,11 @@ export type ConverterContext = {
4444
* contrast with the cell background per WCAG guidelines.
4545
*/
4646
backgroundColor?: string;
47+
/**
48+
* Default table style ID from `w:defaultTableStyle` in document settings.
49+
* Used by table creation paths to determine which style to apply to new tables.
50+
*/
51+
defaultTableStyleId?: string;
4752
};
4853

4954
/**

0 commit comments

Comments
 (0)