fix: disable calling splitRunToParagraph when unavailable (#2557)

* fix: disable calling splitRunToParagraph when unavailable

* fix: add tr.setMeta check helper

* fix: remove extra setMeta check

* test: add behavior test for Enter in comment editor (SD-2092)

Verifies that pressing Enter inside the comment input creates a
paragraph break instead of throwing an error.

---------

Co-authored-by: Caio Pizzol <caio@harbourshare.com>

Author: VladaHarbour

packages/super-editor/src/core/extensions/keymap.js

@@ -3,16 +3,22 @@ import { Extension } from '../Extension.js';
 import { isIOS } from '../utilities/isIOS.js';
 import { isMacOS } from '../utilities/isMacOS.js';
 
+const dispatchHistoryBoundary = (view) => {
+  const tr = view?.state?.tr;
+  if (!tr) return;
+  view.dispatch?.(closeHistory(tr));
+};
+
 export const handleEnter = (editor) => {
   const { view } = editor;
   // Close the current undo group so this structural action becomes its own undo step.
   // Note: this fires before the command chain, so if no command succeeds (rare — e.g.
   // Enter with no valid split target) an empty undo boundary is created. Acceptable
   // trade-off vs. the complexity of post-hoc closeHistory after commands.first.
-  view?.dispatch?.(closeHistory(view?.state?.tr));
+  dispatchHistoryBoundary(view);
 
   return editor.commands.first(({ commands }) => [
-    () => commands.splitRunToParagraph(),
+    () => commands.splitRunToParagraph?.() ?? false,
     () => commands.newlineInCode(),
     () => commands.createParagraphNear(),
     () => commands.liftEmptyBlock(),
@@ -23,7 +29,7 @@ export const handleEnter = (editor) => {
 export const handleBackspace = (editor) => {
   const { view } = editor;
   // Close undo group — see comment in handleEnter.
-  view?.dispatch?.(closeHistory(view?.state?.tr));
+  dispatchHistoryBoundary(view);
 
   return editor.commands.first(({ commands, tr }) => [
     () => commands.undoInputRule(),
@@ -45,7 +51,7 @@ export const handleBackspace = (editor) => {
 export const handleDelete = (editor) => {
   const { view } = editor;
   // Close undo group — see comment in handleEnter.
-  view?.dispatch?.(closeHistory(view?.state?.tr));
+  dispatchHistoryBoundary(view);
 
   return editor.commands.first(({ commands }) => [
     () => commands.deleteSkipEmptyRun(),

packages/super-editor/src/core/extensions/keymap.test.js

@@ -1,4 +1,5 @@
 import { describe, it, expect, vi } from 'vitest';
+import { handleEnter } from './keymap.js';
 
 const setupKeymap = async ({ isMacOS, isIOS }) => {
   vi.resetModules();
@@ -25,6 +26,37 @@ const setupKeymap = async ({ isMacOS, isIOS }) => {
 };
 
 describe('Keymap extension', () => {
+  it('falls back when splitRunToParagraph is unavailable', () => {
+    const splitBlock = vi.fn(() => true);
+    const first = vi.fn((resolver) => {
+      const chain = resolver({
+        commands: {
+          newlineInCode: vi.fn(() => false),
+          createParagraphNear: vi.fn(() => false),
+          liftEmptyBlock: vi.fn(() => false),
+          splitBlock,
+        },
+      });
+
+      for (const command of chain) {
+        if (command()) return true;
+      }
+
+      return false;
+    });
+
+    const editor = {
+      view: {
+        state: { tr: { setMeta: vi.fn(() => ({})) } },
+        dispatch: vi.fn(),
+      },
+      commands: { first },
+    };
+
+    expect(handleEnter(editor)).toBe(true);
+    expect(splitBlock).toHaveBeenCalledTimes(1);
+  });
+
   it('maps Ctrl-a to selectAll on macOS', async () => {
     const { bindings, editor } = await setupKeymap({ isMacOS: true, isIOS: false });
 

tests/behavior/tests/comments/comment-enter-paragraph-break.spec.ts

@@ -0,0 +1,49 @@
+import { test, expect } from '../../fixtures/superdoc.js';
+import { assertDocumentApiReady } from '../../helpers/document-api.js';
+import { addCommentViaUI, activateCommentDialog } from '../../helpers/comments.js';
+
+test.use({ config: { toolbar: 'full', comments: 'on' } });
+
+test('comment with multi-paragraph text renders correctly (SD-2092)', async ({ superdoc }) => {
+  await assertDocumentApiReady(superdoc.page);
+
+  await superdoc.type('hello world');
+  await superdoc.waitForStable();
+
+  // Add a comment, then edit it with multi-paragraph content
+  await addCommentViaUI(superdoc, { textToSelect: 'world', commentText: 'placeholder' });
+  await superdoc.waitForStable();
+
+  // Activate the comment and enter edit mode
+  const dialog = await activateCommentDialog(superdoc, 'world');
+  await dialog.locator('.overflow-icon').click();
+  await superdoc.waitForStable();
+
+  const editOption = superdoc.page.locator('.comments-dropdown__option-label', { hasText: 'Edit' });
+  await expect(editOption.first()).toBeVisible({ timeout: 5_000 });
+  await editOption.first().click();
+  await superdoc.waitForStable();
+
+  // Set multi-paragraph content in the edit input.
+  // This simulates what ProseMirror's splitBlock produces when Enter is pressed.
+  const editInput = dialog.locator('.reply-expanded .superdoc-field .ProseMirror').first();
+  await expect(editInput).toBeVisible({ timeout: 5_000 });
+  await editInput.evaluate((el) => {
+    el.innerHTML = '<p>first line</p><p>second line</p>';
+    el.dispatchEvent(new Event('input', { bubbles: true }));
+  });
+  await superdoc.waitForStable();
+
+  // Save the edited comment
+  await dialog.locator('.reply-expanded .sd-button.primary', { hasText: 'Update' }).click();
+  await superdoc.waitForStable();
+
+  // Verify the comment renders with two paragraphs
+  const updatedDialog = superdoc.page.locator('.comment-placeholder .comments-dialog');
+  const commentBody = updatedDialog.locator('.comment-body .comment').first();
+  await expect(commentBody.locator('p')).toHaveCount(2, { timeout: 10_000 });
+  await expect(commentBody.locator('p').first()).toContainText('first line');
+  await expect(commentBody.locator('p').last()).toContainText('second line');
+
+  await superdoc.snapshot('comment with paragraph break');
+});