Skip to content

Commit 88d07f6

Browse files
committed
fix(ci): use if:always() on validate job to prevent skip bypass
Match the ci-behavior pattern: validate job always runs and explicitly checks for failures. Without if:always(), a skipped or cancelled dependency would skip validate too — meaning the required status check never reports, allowing merge without CI passing.
1 parent 9a91465 commit 88d07f6

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

.github/workflows/ci-superdoc.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,12 @@ jobs:
199199
run: pnpm run test:cli
200200

201201
validate:
202+
if: always()
202203
needs: [build, unit-tests, cli-tests]
203204
runs-on: ubuntu-latest
204205
steps:
205-
- run: echo "All checks passed"
206+
- name: Check results
207+
run: |
208+
if [[ "${{ contains(needs.*.result, 'failure') }}" == "true" ]]; then
209+
exit 1
210+
fi

0 commit comments

Comments
 (0)