Merge remote-tracking branch 'origin/main' into colep/sd-2222-bug-undoredo-on-a-tracked-change-not-bringing-back-the-tc

Author: palmer-cl

.github/workflows/ci-superdoc.yml

@@ -77,9 +77,6 @@ jobs:
       - name: Run slow tests
         run: pnpm test:slow
 
-      - name: Consumer typecheck (skipLibCheck off)
-        run: bash packages/superdoc/tests/consumer-types/run.sh
-
       - name: Install Playwright for UMD smoke test
         run: pnpm --filter @superdoc/umd-smoke-test exec playwright install --with-deps chromium
 

.github/workflows/deploy-demos.yml

@@ -50,6 +50,7 @@ jobs:
         run: pnpm --filter superdoc-esign-demo build
         env:
           VITE_BASE_PATH: /esign/
+          VITE_API_BASE_URL: https://esign-demo-proxy-server-191591660773.us-central1.run.app
 
       - name: Prepare combined publish directory
         run: |

.gitignore

@@ -103,3 +103,5 @@ packages/sdk/langs/python/superdoc/generated/
 packages/sdk/tools/*.json
 # Note: apps/docs/document-api/reference/ stays committed because Mintlify
 # deploys directly from git with no pre-build hook support.
+
+.playwright-cli/

apps/cli/package.json

@@ -10,8 +10,11 @@
     "skill"
   ],
   "scripts": {
+    "predev": "node scripts/ensure-superdoc-build.js",
     "dev": "bun run src/index.ts",
+    "prebuild": "node scripts/ensure-superdoc-build.js",
     "build": "bun build src/index.ts --outdir dist --target node --format esm",
+    "prebuild:native": "node scripts/ensure-superdoc-build.js",
     "build:native": "bun build src/index.ts --compile --outfile dist/superdoc",
     "build:native:all": "node scripts/build-native-cli.js --all",
     "build:native:host": "node scripts/build-native-cli.js",
@@ -20,10 +23,12 @@
     "build:prepublish": "node scripts/build-and-stage.js",
     "publish:platforms": "node scripts/publish.js --tag latest",
     "publish:platforms:dry": "node scripts/publish.js --tag latest --dry-run",
+    "pretest": "node scripts/ensure-superdoc-build.js",
     "test": "NODE_ENV=test bun test",
     "lint": "eslint .",
     "lint:fix": "eslint --fix .",
     "format": "prettier --write .",
+    "pretypecheck": "node scripts/ensure-superdoc-build.js --types",
     "typecheck": "tsc --noEmit -p tsconfig.check.json",
     "prepublishOnly": "pnpm run build",
     "release": "pnpx semantic-release",

apps/cli/scripts/build-native-cli.js

@@ -4,6 +4,7 @@ import { existsSync, mkdirSync, readFileSync } from 'node:fs';
 import path from 'node:path';
 import { spawnSync } from 'node:child_process';
 import { cliRoot, ensureNoUnknownFlags, getOptionalFlagValue, isDirectExecution, repoRoot } from './utils.js';
+import { ensureSuperdocBuild } from './ensure-superdoc-build.js';
 
 const cliEntry = path.join(cliRoot, 'src/index.ts');
 const cliPackagePath = path.join(cliRoot, 'package.json');
@@ -155,6 +156,7 @@ async function writeManifest(entries) {
  */
 export async function main(argv = process.argv.slice(2)) {
   ensureNoUnknownFlags(argv, allowedFlags);
+  ensureSuperdocBuild();
   const targets = resolveRequestedTargets(argv);
   const hostTarget = resolveHostTargetId();
 

apps/cli/scripts/ensure-superdoc-build.js

@@ -0,0 +1,43 @@
+import path from 'node:path';
+import { ensureNoUnknownFlags, isDirectExecution, repoRoot, runCommand } from './utils.js';
+
+const allowedFlags = new Set(['--types']);
+const superdocRoot = path.join(repoRoot, 'packages/superdoc');
+
+/**
+ * Ensures the packaged `superdoc` runtime exists for CLI entrypoints that now
+ * consume `superdoc/super-editor` instead of raw `@superdoc/super-editor/*` source.
+ *
+ * `--types` performs the full published build so package type exports exist.
+ * Without it, a faster runtime-only build is sufficient for Bun execution.
+ *
+ * @param {{ includeTypes?: boolean }} [options]
+ * @returns {void}
+ */
+export function ensureSuperdocBuild(options = {}) {
+  const includeTypes = options.includeTypes === true;
+  const scriptName = includeTypes ? 'build:es' : 'build:dev';
+  const label = includeTypes ? 'Build packaged SuperDoc runtime and types' : 'Build packaged SuperDoc runtime';
+
+  runCommand('pnpm', ['--prefix', superdocRoot, 'run', scriptName], label);
+}
+
+/**
+ * CLI wrapper around {@link ensureSuperdocBuild}.
+ *
+ * @param {string[]} [argv=process.argv.slice(2)]
+ * @returns {void}
+ */
+export function main(argv = process.argv.slice(2)) {
+  ensureNoUnknownFlags(argv, allowedFlags);
+  ensureSuperdocBuild({ includeTypes: argv.includes('--types') });
+}
+
+if (isDirectExecution(import.meta.url)) {
+  try {
+    main();
+  } catch (error) {
+    console.error(error instanceof Error ? error.message : error);
+    process.exitCode = 1;
+  }
+}

apps/cli/src/__tests__/cli.test.ts

@@ -3,6 +3,7 @@ import { access, copyFile, mkdir, readFile, rm, writeFile } from 'node:fs/promis
 import { join } from 'node:path';
 import { run } from '../index';
 import { resolveListDocFixture, resolveSourceDocFixture } from './fixtures';
+import { writeListDocWithoutParaIds } from './unstable-list-fixture';
 
 type RunResult = {
   code: number;
@@ -1218,6 +1219,55 @@ describe('superdoc CLI', () => {
     expect(getEnvelope.data.item.address.nodeId).toBe(address.nodeId);
   });
 
+  test('lists list/get keep list item addresses stable for docs without paraIds in stateless mode', async () => {
+    const source = join(TEST_DIR, 'lists-no-paraids-stateless.docx');
+    await writeListDocWithoutParaIds(source);
+
+    const address = await firstListItemAddress(['lists', 'list', source, '--limit', '1']);
+
+    const getResult = await runCli(['lists', 'get', source, '--address-json', JSON.stringify(address)]);
+    expect(getResult.code).toBe(0);
+
+    const getEnvelope = parseJsonOutput<
+      SuccessEnvelope<{
+        address: ListItemAddress;
+        item: { address: ListItemAddress };
+      }>
+    >(getResult);
+    expect(getEnvelope.data.item.address.nodeId).toBe(address.nodeId);
+
+    const secondAddress = await firstListItemAddress(['lists', 'list', source, '--limit', '1']);
+    expect(secondAddress.nodeId).toBe(address.nodeId);
+  });
+
+  test('lists list/get keep list item addresses stable for docs without paraIds in stateful mode', async () => {
+    const source = join(TEST_DIR, 'lists-no-paraids-stateful.docx');
+    await writeListDocWithoutParaIds(source);
+
+    try {
+      const openResult = await runCli(['open', source]);
+      expect(openResult.code).toBe(0);
+
+      const address = await firstListItemAddress(['lists', 'list', '--limit', '1']);
+
+      const getResult = await runCli(['lists', 'get', '--address-json', JSON.stringify(address)]);
+      expect(getResult.code).toBe(0);
+
+      const getEnvelope = parseJsonOutput<
+        SuccessEnvelope<{
+          address: ListItemAddress;
+          item: { address: ListItemAddress };
+        }>
+      >(getResult);
+      expect(getEnvelope.data.item.address.nodeId).toBe(address.nodeId);
+
+      const secondAddress = await firstListItemAddress(['lists', 'list', '--limit', '1']);
+      expect(secondAddress.nodeId).toBe(address.nodeId);
+    } finally {
+      await runCli(['close', '--discard']);
+    }
+  });
+
   test('lists list pretty prints list rows', async () => {
     const result = await runCli(['lists', 'list', LIST_SAMPLE_DOC, '--limit', '2', '--output', 'pretty']);
     expect(result.code).toBe(0);

apps/cli/src/__tests__/conformance/scenarios.ts

@@ -590,31 +590,6 @@ function cellMutationScenario(
   };
 }
 
-/** Table-scoped mutation in a session: uses --table-node-id instead of --node-id. */
-function tableScopedMutationScenario(
-  op: string,
-  extraArgs: string[],
-): (harness: ConformanceHarness) => Promise<ScenarioInvocation> {
-  return async (harness) => {
-    const label = `table-${op.replace(/\./g, '-')}`;
-    const stateDir = await harness.createStateDir(`${label}-success`);
-    const { tableNodeId, sessionId } = await harness.createTableFixture(stateDir, label);
-    return {
-      stateDir,
-      args: [
-        ...commandTokens(`doc.${op}` as CliOperationId),
-        '--session',
-        sessionId,
-        '--table-node-id',
-        tableNodeId,
-        ...extraArgs,
-        '--out',
-        harness.createOutputPath(`${label}-out`),
-      ],
-    };
-  };
-}
-
 function tocMutationScenario(
   op: string,
   extraArgs: string[],
@@ -2983,9 +2958,9 @@ export const SUCCESS_SCENARIOS = {
   'doc.tables.split': tableMutationScenario('tables.split', ['--at-row-index', '1']),
   'doc.tables.convertToText': tableMutationScenario('tables.convertToText', ['--delimiter', 'tab']),
   'doc.tables.setLayout': tableMutationScenario('tables.setLayout', ['--alignment', 'center']),
-  'doc.tables.insertRow': tableScopedMutationScenario('tables.insertRow', ['--row-index', '0', '--position', 'below']),
-  'doc.tables.deleteRow': tableScopedMutationScenario('tables.deleteRow', ['--row-index', '0']),
-  'doc.tables.setRowHeight': tableScopedMutationScenario('tables.setRowHeight', [
+  'doc.tables.insertRow': tableMutationScenario('tables.insertRow', ['--row-index', '0', '--position', 'below']),
+  'doc.tables.deleteRow': tableMutationScenario('tables.deleteRow', ['--row-index', '0']),
+  'doc.tables.setRowHeight': tableMutationScenario('tables.setRowHeight', [
     '--row-index',
     '0',
     '--height-pt',
@@ -2994,19 +2969,19 @@ export const SUCCESS_SCENARIOS = {
     'atLeast',
   ]),
   'doc.tables.distributeRows': tableMutationScenario('tables.distributeRows', []),
-  'doc.tables.setRowOptions': tableScopedMutationScenario('tables.setRowOptions', [
+  'doc.tables.setRowOptions': tableMutationScenario('tables.setRowOptions', [
     '--row-index',
     '0',
     '--allow-break-across-pages',
   ]),
-  'doc.tables.insertColumn': tableScopedMutationScenario('tables.insertColumn', [
+  'doc.tables.insertColumn': tableMutationScenario('tables.insertColumn', [
     '--column-index',
     '0',
     '--position',
     'right',
   ]),
-  'doc.tables.deleteColumn': tableScopedMutationScenario('tables.deleteColumn', ['--column-index', '0']),
-  'doc.tables.setColumnWidth': tableScopedMutationScenario('tables.setColumnWidth', [
+  'doc.tables.deleteColumn': tableMutationScenario('tables.deleteColumn', ['--column-index', '0']),
+  'doc.tables.setColumnWidth': tableMutationScenario('tables.setColumnWidth', [
     '--column-index',
     '0',
     '--width-pt',
@@ -3015,7 +2990,7 @@ export const SUCCESS_SCENARIOS = {
   'doc.tables.distributeColumns': tableMutationScenario('tables.distributeColumns', []),
   'doc.tables.insertCell': cellMutationScenario('tables.insertCell', ['--mode', 'shiftRight']),
   'doc.tables.deleteCell': cellMutationScenario('tables.deleteCell', ['--mode', 'shiftLeft']),
-  'doc.tables.mergeCells': tableScopedMutationScenario('tables.mergeCells', [
+  'doc.tables.mergeCells': tableMutationScenario('tables.mergeCells', [
     '--start-json',
     JSON.stringify({ rowIndex: 0, columnIndex: 0 }),
     '--end-json',