Skip to content

Commit b9ad331

Browse files
committed
fix(document-api): apply correct track-changes meta on structural-end inserts
1 parent e3aad76 commit b9ad331

3 files changed

Lines changed: 6 additions & 4 deletions

File tree

packages/super-editor/src/document-api-adapters/plan-engine/plan-wrappers.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ import {
4343
rejectTrackedMode,
4444
} from '../helpers/mutation-helpers.js';
4545
import { TrackFormatMarkName } from '../../extensions/track-changes/constants.js';
46-
import { applyTrackedMutationMeta } from '../helpers/transaction-meta.js';
46+
import { applyDirectMutationMeta, applyTrackedMutationMeta } from '../helpers/transaction-meta.js';
4747
import { markdownToPmFragment } from '../../core/helpers/markdown/markdownToPmContent.js';
4848
import { processContent } from '../../core/helpers/contentProcessor.js';
4949

@@ -285,7 +285,8 @@ export function writeWrapper(editor: Editor, request: WriteRequest, options?: Mu
285285
const receipt = executeDomainCommand(
286286
editor,
287287
(): boolean => {
288-
insertParagraphAtEnd(editor, insertPos, text, mode === 'tracked' ? applyTrackedMutationMeta : undefined);
288+
const meta = mode === 'tracked' ? applyTrackedMutationMeta : applyDirectMutationMeta;
289+
insertParagraphAtEnd(editor, insertPos, text, meta);
289290
return true;
290291
},
291292
{ expectedRevision: options?.expectedRevision },

packages/super-editor/src/document-api-adapters/write-adapter.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -707,8 +707,9 @@ describe('writeAdapter', () => {
707707
);
708708

709709
expect(receipt.success).toBe(true);
710-
// Structural-end: creates a paragraph at doc.content.size (2)
710+
// Structural-end: creates a paragraph at doc.content.size (2) with direct meta
711711
expect(tr.insert).toHaveBeenCalledWith(2, expect.anything());
712+
expect(tr.setMeta).toHaveBeenCalledWith('skipTrackChanges', true);
712713
expect(dispatch).toHaveBeenCalledTimes(1);
713714
});
714715

packages/super-editor/src/document-api-adapters/write-adapter.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ function applyDirectWrite(editor: Editor, request: WriteRequest, resolvedTarget:
167167
// Structural-end: create a paragraph at the document end, since raw
168168
// insertText cannot place text between block nodes.
169169
if (resolvedTarget.structuralEnd) {
170-
insertParagraphAtEnd(editor, resolvedTarget.range.from, request.text ?? '');
170+
insertParagraphAtEnd(editor, resolvedTarget.range.from, request.text ?? '', applyDirectMutationMeta);
171171
return { success: true, resolution: resolvedTarget.resolution };
172172
}
173173

0 commit comments

Comments
 (0)