Skip to content

Commit d34ec3f

Browse files
committed
Revert "fix(react): restore contained prop lost during rebase"
This reverts commit 92ad0c4.
1 parent 92ad0c4 commit d34ec3f

2 files changed

Lines changed: 3 additions & 18 deletions

File tree

packages/react/src/SuperDocEditor.tsx

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ function SuperDocEditorInner(props: SuperDocEditorProps, ref: ForwardedRef<Super
3838
id,
3939
renderLoading,
4040
hideToolbar = false,
41-
contained = false,
4241
className,
4342
style,
4443
// Callbacks (stored in ref to avoid triggering rebuilds)
@@ -150,7 +149,6 @@ function SuperDocEditorInner(props: SuperDocEditorProps, ref: ForwardedRef<Super
150149
...(!hideToolbar && toolbarContainerRef.current ? { toolbar: `#${CSS.escape(toolbarId)}` } : {}),
151150
documentMode,
152151
role,
153-
contained,
154152
...(documentProp != null ? { document: documentProp } : {}),
155153
...(user ? { user } : {}),
156154
...(users ? { users } : {}),
@@ -226,26 +224,17 @@ function SuperDocEditorInner(props: SuperDocEditorProps, ref: ForwardedRef<Super
226224
// initial values - use getInstance() methods to change them at runtime.
227225
// Note: restProps is intentionally excluded to avoid rebuilds on every render.
228226
// documentMode is handled separately via setDocumentMode() for efficiency.
229-
}, [documentProp, user, users, modules, role, hideToolbar, contained, containerId, toolbarId]);
227+
}, [documentProp, user, users, modules, role, hideToolbar, containerId, toolbarId]);
230228

231229
const wrapperClassName = ['superdoc-wrapper', className].filter(Boolean).join(' ');
232230
const hideWhenLoading: CSSProperties | undefined = isLoading ? { display: 'none' } : undefined;
233231

234-
const wrapperStyle: CSSProperties = {
235-
...style,
236-
...(contained && { display: 'flex', flexDirection: 'column' as const }),
237-
};
238-
239232
return (
240-
<div className={wrapperClassName} style={wrapperStyle}>
233+
<div className={wrapperClassName} style={style}>
241234
{!hideToolbar && (
242235
<div ref={toolbarContainerRef} id={toolbarId} className='superdoc-toolbar-container' style={hideWhenLoading} />
243236
)}
244-
<div
245-
id={containerId}
246-
className='superdoc-editor-container'
247-
style={{ ...hideWhenLoading, ...(contained && { flex: 1, minHeight: 0 }) }}
248-
/>
237+
<div id={containerId} className='superdoc-editor-container' style={hideWhenLoading} />
249238
{isLoading && !hasError && renderLoading && <div className='superdoc-loading-container'>{renderLoading()}</div>}
250239
{hasError && <div className='superdoc-error-container'>Failed to load editor. Check console for details.</div>}
251240
</div>

packages/react/src/types.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -136,10 +136,6 @@ interface ReactProps {
136136
/** Hide the toolbar container. When true, no toolbar is rendered. @default false */
137137
hideToolbar?: boolean;
138138

139-
/** Enable contained mode for fixed-height container embedding. When true, SuperDoc
140-
* fits within its parent's height and scrolls internally. @default false */
141-
contained?: boolean;
142-
143139
/** Additional CSS class name for the wrapper element */
144140
className?: string;
145141

0 commit comments

Comments
 (0)