Skip to content

Commit ddc751a

Browse files
authored
fix(types): drop accidental BasicUpload public re-export (SD-2893) (#3151)
BasicUpload was re-exported through `superdoc/super-editor` and `superdoc` despite being marked `@internal` at the export site (packages/super-editor/src/editors/v1/index.js:103). It is not documented in any README, AGENTS guide, or example. The two dev components that use it (SuperdocDev.vue, DeveloperPlayground.vue) import it directly from `@superdoc/common/components/BasicUpload.vue`, not via the public re-export. Drop the re-export rather than relocating the .vue file. The upload widget is dev-tooling, not a public API. The bare `@superdoc/common/components/BasicUpload.vue` shim entry goes away because no public d.ts file references it anymore. Also removes the BasicUpload assertion from the consumer-typecheck customer-scenario fixture so the matrix stays green; the fixture was the only place the public re-export was exercised. Shim count: 3 to 2. Remaining: @superdoc/common (5 dist refs, catch-all bin), @superdoc/style-engine/ooxml (10 dist refs). Verified: build:es clean (8 guarded packages, 2 shim modules), consumer matrix 47/0/0, runtime smoke 4/4 with BasicUpload explicitly asserted absent from main and super-editor entries.
1 parent 806451a commit ddc751a

3 files changed

Lines changed: 0 additions & 7 deletions

File tree

packages/super-editor/src/editors/v1/index.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ import { Mark } from '@core/Mark.js';
3333
import ContextMenu from './components/context-menu/ContextMenu.vue';
3434
/** @deprecated Use ContextMenu instead */
3535
const SlashMenu = ContextMenu;
36-
import BasicUpload from '@superdoc/common/components/BasicUpload.vue';
3736

3837
import SuperEditor from './components/SuperEditor.vue';
3938
import Toolbar from './components/toolbar/Toolbar.vue';
@@ -100,8 +99,6 @@ export {
10099
SuperEditor,
101100
/** @internal */
102101
SuperInput,
103-
/** @internal */
104-
BasicUpload,
105102
Toolbar,
106103
AIWriter,
107104
ContextMenu,

packages/superdoc/src/index.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ import {
2828
// Vue components
2929
SuperEditor,
3030
SuperInput,
31-
BasicUpload,
3231
Toolbar,
3332
AIWriter,
3433
ContextMenu,
@@ -289,7 +288,6 @@ export {
289288
// Vue components
290289
SuperEditor,
291290
SuperInput,
292-
BasicUpload,
293291
Toolbar,
294292
AIWriter,
295293
ContextMenu,

tests/consumer-typecheck/src/customer-scenario.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ import {
4242
CommentsPluginKey,
4343
SuperEditor,
4444
SuperInput,
45-
BasicUpload,
4645
Toolbar,
4746
AIWriter,
4847
ContextMenu,
@@ -831,7 +830,6 @@ function testAdditionalClasses() {
831830
function testVueComponents() {
832831
const superEditor = SuperEditor;
833832
const superInput = SuperInput;
834-
const basicUpload = BasicUpload;
835833
const toolbarComponent = Toolbar;
836834
const aiWriter = AIWriter;
837835
const contextMenu = ContextMenu;

0 commit comments

Comments
 (0)