fix(document-api): preserve markdown table style metadata in structural writes

Author: harbournick

packages/document-api/src/receipt-bridge.ts

@@ -38,9 +38,9 @@ export function textReceiptToSDReceipt(receipt: TextMutationReceipt): SDMutation
       success: true,
       resolution: receipt.resolution
         ? {
-            requestedTarget: receipt.resolution.requestedTarget
-              ? textAddressToSDAddress(receipt.resolution.requestedTarget)
-              : undefined,
+            ...(receipt.resolution.requestedTarget
+              ? { requestedTarget: textAddressToSDAddress(receipt.resolution.requestedTarget) }
+              : {}),
             target: textAddressToSDAddress(receipt.resolution.target),
           }
         : undefined,
@@ -75,9 +75,9 @@ export function textReceiptToSDReceipt(receipt: TextMutationReceipt): SDMutation
     failure,
     resolution: receipt.resolution
       ? {
-          requestedTarget: receipt.resolution.requestedTarget
-            ? textAddressToSDAddress(receipt.resolution.requestedTarget)
-            : undefined,
+          ...(receipt.resolution.requestedTarget
+            ? { requestedTarget: textAddressToSDAddress(receipt.resolution.requestedTarget) }
+            : {}),
           target: textAddressToSDAddress(receipt.resolution.target),
         }
       : undefined,

packages/super-editor/src/document-api-adapters/helpers/sd-projection.test.ts

@@ -3,6 +3,7 @@ import { initTestEditor, loadTestDataForEditorTests } from '@tests/helpers/helpe
 import type { Editor } from '../../core/Editor.js';
 import { projectContentNode, projectInlineNode, projectDocument } from './sd-projection.js';
 import { executeStructuralInsert } from '../structural-write-engine/index.js';
+import { markdownToPmFragment } from '../../core/helpers/markdown/markdownToPmContent.js';
 import type { SDFragment, SDParagraph, SDHeading, SDTable, SDRun, SDHyperlink } from '@superdoc/document-api';
 
 let docData: Awaited<ReturnType<typeof loadTestDataForEditorTests>>;
@@ -138,6 +139,16 @@ describe('projectContentNode', () => {
     expect(projected.table.rows[0].cells[0].content.length).toBeGreaterThan(0);
   });
 
+  it('projects markdown table width and normalization marker', () => {
+    const { fragment } = markdownToPmFragment('| Col A | Col B |\n| --- | --- |\n| foo | bar |', editor);
+    expect(fragment.childCount).toBeGreaterThan(0);
+
+    const projected = projectContentNode(fragment.child(0)) as SDTable;
+    expect(projected.kind).toBe('table');
+    expect(projected.table.props?.width).toEqual({ kind: 'percent', value: 5000 });
+    expect((projected.ext as any)?.superdoc?.needsTableStyleNormalization).toBe(true);
+  });
+
   it('preserves sdBlockId as id', () => {
     executeStructuralInsert(editor, {
       content: {

packages/super-editor/src/document-api-adapters/helpers/sd-projection.ts

@@ -418,6 +418,7 @@ function buildHeading(
 
 function projectTable(pmNode: ProseMirrorNode): SDTable {
   const attrs = pmNode.attrs as TableAttrs | undefined;
+  const pmAttrs = pmNode.attrs as Record<string, unknown>;
   const rows: SDTableRow[] = [];
 
   pmNode.forEach((child) => {
@@ -432,14 +433,31 @@ function projectTable(pmNode: ProseMirrorNode): SDTable {
     table: { rows },
   };
 
-  const styleRef = attrs?.tableProperties?.tableStyleId ?? (pmNode.attrs as any)?.tableStyleId;
+  const styleRef = attrs?.tableProperties?.tableStyleId ?? (pmAttrs as any)?.tableStyleId;
   if (styleRef) result.table.styleRef = styleRef;
 
-  const gridModel = (pmNode.attrs as any)?.tableGridModel ?? attrs?.tableGrid?.colWidths;
+  const props = extractTableProps(attrs, pmAttrs);
+  if (props) result.table.props = props;
+
+  const gridModel = (pmAttrs as any)?.grid ?? (pmAttrs as any)?.tableGridModel ?? attrs?.tableGrid?.colWidths;
   if (gridModel && Array.isArray(gridModel)) {
-    result.table.columns = gridModel.map((item: any) => ({
-      width: typeof item === 'number' ? item : (item?.col ?? item?.width),
-    }));
+    const columns = gridModel
+      .map((item: any) => (typeof item === 'number' ? item : (item?.col ?? item?.width)))
+      .filter((width: unknown): width is number => typeof width === 'number' && Number.isFinite(width))
+      .map((width: number) => ({ width }));
+    if (columns.length > 0) {
+      result.table.columns = columns;
+    }
+  }
+
+  if ((pmAttrs as any)?.needsTableStyleNormalization === true) {
+    const ext = isRecord(result.ext) ? { ...result.ext } : {};
+    const superdocExt = isRecord(ext.superdoc) ? { ...(ext.superdoc as Record<string, unknown>) } : {};
+    superdocExt.needsTableStyleNormalization = true;
+    result.ext = {
+      ...ext,
+      superdoc: superdocExt,
+    };
   }
 
   return result;
@@ -986,6 +1004,82 @@ function resolveNodeId(pmNode: ProseMirrorNode): string | undefined {
   return typeof id === 'string' && id.length > 0 ? id : undefined;
 }
 
+function isRecord(value: unknown): value is Record<string, unknown> {
+  return value !== null && typeof value === 'object' && !Array.isArray(value);
+}
+
+function extractTableProps(
+  attrs: TableAttrs | undefined,
+  pmAttrs: Record<string, unknown>,
+): SDTable['table']['props'] | undefined {
+  const tableProps = attrs?.tableProperties as Record<string, unknown> | null | undefined;
+  const props: NonNullable<SDTable['table']['props']> = {};
+  let hasProps = false;
+
+  const width = extractTableWidth((tableProps as any)?.tableWidth ?? (pmAttrs as any)?.tableWidth);
+  if (width) {
+    props.width = width;
+    hasProps = true;
+  }
+
+  const layout = (tableProps as any)?.tableLayout ?? (pmAttrs as any)?.tableLayout;
+  if (layout === 'fixed' || layout === 'autofit') {
+    props.layout = layout;
+    hasProps = true;
+  }
+
+  const alignment = mapTableAlignmentToSD((tableProps as any)?.justification ?? (pmAttrs as any)?.justification);
+  if (alignment) {
+    props.alignment = alignment;
+    hasProps = true;
+  }
+
+  return hasProps ? props : undefined;
+}
+
+function mapTableAlignmentToSD(value: unknown): NonNullable<SDTable['table']['props']>['alignment'] | undefined {
+  if (typeof value !== 'string') return undefined;
+  switch (value) {
+    case 'start':
+    case 'left':
+      return 'left';
+    case 'end':
+    case 'right':
+      return 'right';
+    case 'center':
+    case 'inside':
+    case 'outside':
+      return value;
+    default:
+      return undefined;
+  }
+}
+
+function extractTableWidth(width: unknown): NonNullable<SDTable['table']['props']>['width'] | undefined {
+  if (!isRecord(width)) return undefined;
+
+  const type = typeof width.type === 'string' ? width.type.toLowerCase() : undefined;
+  const value =
+    typeof width.value === 'number' ? width.value : typeof width.width === 'number' ? width.width : undefined;
+
+  if (type === 'auto') {
+    return { kind: 'auto' };
+  }
+  if (type === 'nil' || type === 'none') {
+    return { kind: 'none' };
+  }
+  if (type === 'pct' && typeof value === 'number' && Number.isFinite(value)) {
+    return { kind: 'percent', value };
+  }
+  if (type === 'dxa' && typeof value === 'number' && Number.isFinite(value)) {
+    return { kind: 'points', value: value / 20 };
+  }
+  if (typeof value === 'number' && Number.isFinite(value)) {
+    return { kind: 'points', value };
+  }
+  return undefined;
+}
+
 // ---------------------------------------------------------------------------
 // Helpers: paragraph properties extraction
 // ---------------------------------------------------------------------------

packages/super-editor/src/document-api-adapters/structural-write-engine/index.ts

@@ -173,17 +173,36 @@ function validateSectionReferences(editor: Editor, fragment: SDFragment): void {
   }
 }
 
-/** Recursively collects targetSectionId values from sectionBreak nodes. */
+/** Recursively collects targetSectionId values from sectionBreak nodes at any depth. */
 function collectSectionRefIds(nodes: SDContentNode[]): string[] {
   const refIds: string[] = [];
-  for (const node of nodes) {
-    if (node.kind === 'sectionBreak' && 'sectionBreak' in node) {
-      const payload = (node as { sectionBreak: { targetSectionId?: string } }).sectionBreak;
-      if (payload.targetSectionId) {
-        refIds.push(payload.targetSectionId);
+  const visit = (children: SDContentNode[]) => {
+    for (const node of children) {
+      if (node.kind === 'sectionBreak' && 'sectionBreak' in node) {
+        const payload = (node as { sectionBreak: { targetSectionId?: string } }).sectionBreak;
+        if (payload.targetSectionId) {
+          refIds.push(payload.targetSectionId);
+        }
+      }
+      // Recurse into container nodes
+      if (node.kind === 'list') {
+        for (const item of node.list.items) {
+          visit(item.content);
+        }
+      } else if (node.kind === 'table') {
+        for (const row of node.table.rows) {
+          for (const cell of row.cells) {
+            visit(cell.content);
+          }
+        }
+      } else if (node.kind === 'sdt' && node.sdt.content) {
+        visit(node.sdt.content);
+      } else if (node.kind === 'customXml' && node.customXml.content) {
+        visit(node.customXml.content);
       }
     }
-  }
+  };
+  visit(nodes);
   return refIds;
 }
 

packages/super-editor/src/document-api-adapters/structural-write-engine/nesting-guard.ts

@@ -12,13 +12,40 @@ import { DocumentApiAdapterError } from '../errors.js';
 
 /**
  * Returns true if the fragment contains any table nodes (at any depth).
+ * Recurses into list items, table cells, sdt, and customXml content.
  */
 function fragmentContainsTable(fragment: SDFragment): boolean {
   const nodes: SDContentNode[] = Array.isArray(fragment) ? fragment : [fragment];
-  return nodes.some((node) => {
-    const kind = (node as any).kind ?? (node as any).type;
-    return kind === 'table';
-  });
+  return nodes.some(nodeContainsTable);
+}
+
+function nodeContainsTable(node: SDContentNode): boolean {
+  const kind = (node as any).kind ?? (node as any).type;
+  if (kind === 'table') return true;
+
+  const children = getChildContentNodes(node);
+  return children.some(nodeContainsTable);
+}
+
+/** Extracts nested SDContentNode children from container nodes. */
+function getChildContentNodes(node: SDContentNode): SDContentNode[] {
+  const children: SDContentNode[] = [];
+  if (node.kind === 'list') {
+    for (const item of node.list.items) {
+      children.push(...item.content);
+    }
+  } else if (node.kind === 'table') {
+    for (const row of node.table.rows) {
+      for (const cell of row.cells) {
+        children.push(...cell.content);
+      }
+    }
+  } else if (node.kind === 'sdt' && node.sdt.content) {
+    children.push(...node.sdt.content);
+  } else if (node.kind === 'customXml' && node.customXml.content) {
+    children.push(...node.customXml.content);
+  }
+  return children;
 }
 
 /**