refactor: address PR review feedback

- Remove unused NodeSelection import from table.js
- Remove dead trailingParagraphPos from insertTopLevelTableWithSeparators
- Remove redundant .map() in findClosestLineInDirection
- Pass pre-computed currentMetrics instead of measuring the element twice

Author: luccas-harbour

packages/super-editor/src/extensions/table/table.js

@@ -188,7 +188,7 @@ import {
 } from '../table-cell/helpers/legacyBorderMigration.js';
 import { isInTable } from '@helpers/isInTable.js';
 import { findParentNode } from '@helpers/findParentNode.js';
-import { NodeSelection, TextSelection, Plugin, PluginKey } from 'prosemirror-state';
+import { TextSelection, Plugin, PluginKey } from 'prosemirror-state';
 import { isCellSelection } from './tableHelpers/isCellSelection.js';
 import {
   addColumnBefore as originalAddColumnBefore,
@@ -274,37 +274,35 @@ function createTableSeparatorParagraph(schema) {
  * @param {number} pos
  * @param {import('prosemirror-model').Node} tableNode
  * @param {{ from?: number, to?: number }} [replaceRange]
- * @returns {{ inserted: boolean, trailingParagraphPos: number | null }}
+ * @returns {{ inserted: boolean }}
  */
 function insertTopLevelTableWithSeparators(tr, doc, pos, tableNode, replaceRange = {}) {
   const replaceFrom = replaceRange.from ?? pos;
   const replaceTo = replaceRange.to ?? pos;
   const sep = tableSeparatorNeeds(doc, pos, replaceRange);
   if (!sep.before && !sep.after) {
     tr.replaceWith(replaceFrom, replaceTo, tableNode);
-    return { inserted: true, trailingParagraphPos: null };
+    return { inserted: true };
   }
 
   const nodes = [];
-  let trailingParagraphPos = null;
 
   if (sep.before) {
     const before = createTableSeparatorParagraph(doc.type.schema);
-    if (!before) return { inserted: false, trailingParagraphPos: null };
+    if (!before) return { inserted: false };
     nodes.push(before);
   }
 
   nodes.push(tableNode);
 
   if (sep.after) {
     const after = createTableSeparatorParagraph(doc.type.schema);
-    if (!after) return { inserted: false, trailingParagraphPos: null };
-    trailingParagraphPos = pos + nodes.reduce((size, node) => size + node.nodeSize, 0);
+    if (!after) return { inserted: false };
     nodes.push(after);
   }
 
   tr.replaceWith(replaceFrom, replaceTo, Fragment.from(nodes));
-  return { inserted: true, trailingParagraphPos };
+  return { inserted: true };
 }
 
 /**

packages/super-editor/src/extensions/vertical-navigation/vertical-navigation.js

@@ -342,7 +342,13 @@ function findAdjacentLineElement(currentLine, direction, caretX) {
   if (!currentLineMetrics) return null;
 
   const currentPageLines = getPageLineElements(page);
-  const adjacentOnCurrentPage = findClosestLineInDirection(currentPageLines, currentLine, direction, caretX);
+  const adjacentOnCurrentPage = findClosestLineInDirection(
+    currentPageLines,
+    currentLine,
+    currentLineMetrics,
+    direction,
+    caretX,
+  );
   if (adjacentOnCurrentPage) return adjacentOnCurrentPage;
 
   const pages = Array.from(page.parentElement?.querySelectorAll?.(`.${pageClass}`) ?? []);
@@ -429,14 +435,12 @@ function getPageLineElements(page) {
  * Chooses the closest visual line in the requested direction.
  * @param {Element[]} lineEls
  * @param {Element} currentLine
+ * @param {NonNullable<ReturnType<typeof getLineMetrics>>} currentMetrics
  * @param {number} direction
  * @param {number} caretX
  * @returns {Element | null}
  */
-function findClosestLineInDirection(lineEls, currentLine, direction, caretX) {
-  const currentMetrics = getLineMetrics(currentLine);
-  if (!currentMetrics) return null;
-
+function findClosestLineInDirection(lineEls, currentLine, currentMetrics, direction, caretX) {
   const directionalCandidates = lineEls
     .filter((line) => line !== currentLine)
     .map((line) => ({ line, metrics: getLineMetrics(line) }))
@@ -464,10 +468,7 @@ function findClosestLineInDirection(lineEls, currentLine, direction, caretX) {
     isWithinTolerance(metrics.centerY, targetRowCenterY, getRowTolerance(currentMetrics, metrics)),
   );
 
-  return chooseLineClosestToX(
-    rowCandidates.map(({ line, metrics }) => ({ line, metrics })),
-    caretX,
-  );
+  return chooseLineClosestToX(rowCandidates, caretX);
 }
 
 /**