Commit ed407d7
authored
feat(content-controls): support richText type and regenerate NDA demo fixture (SD-3131) (#3275)
* feat(content-controls): support richText type and resolve typeless SDTs per ECMA-376 (SD-3131)
Adds 'richText' to ContentControlType so SuperDoc resolves typeless w:sdt
SDTs to 'richText' per ECMA-376 §17.5.2.26 ("If no type element is
specified, then the nearest ancestor structured document tag shall be
of type richText"). Before, typeless SDTs - which Word emits for
ContentControls.Add(0, range) and the default Add($null, range) - fell
through to 'unknown', blocking customers from inspecting Word-authored
controls by type.
- Detection: typeless sdtPr and explicit <w:richText/> both resolve to
'richText'. Unmodeled type children (w:equation, w:picture, w:citation,
w:bibliography, w:docPartList) still return null so resolveControlType
yields 'unknown' - keeping 'unknown' as "unsupported or unrecognized",
not "typeless rich-text control".
- Export/create maps: richText: 'w:richText' in both CONTROL_TYPE_SDT_PR_ELEMENTS
(wrappers) and CONTROL_TYPE_ELEMENT_MAP (converter), plus a 'richText'
case in buildDefaultTypeSdtPrElement so create.contentControl and setType
produce valid OOXML.
- text.setValue stays restricted to actual w:text controls.
Tests: 22 in handle-structured-content-node.test.js (10 new), 39 in
content-controls-wrappers, 1189 in conformance - all pass.
* feat(demos): regenerate NDA fixture with plain-text inline fields (SD-3131)
The contract-templates demo fixture had inline smart fields authored as
default rich-text controls (typeless sdtPr), which is why none of them
detected as 'text' - they fell through to 'unknown' before SD-3131 and
resolve as 'richText' after.
Regenerated nda-template.docx with ContentControls.Add(1, range) for the
7 inline smart fields (now <w:text/> in sdtPr, controlType: 'text') while
leaving the 6 block clauses as typeless (controlType: 'richText').
Verified unzip: 13 SDTs total, 7 <w:text/>, 0 explicit <w:richText/>.
Switched per-occurrence field update from replaceContent to text.setValue
to exercise the typed API. Clause replacement stays on replaceContent
because rich-text controls don't have a typed setter.
README/JSDoc updated: "seven inline plain-text + six block rich-text"
(was "thirteen plain-text"). Honest limits section updated to reflect
the API split.
Browser smoke verified: receivingParty fan-out updates 2/2 occurrences
(header + nested), clause replacement decrements "updates available"
correctly, summary line accurate.1 parent 3c549c9 commit ed407d7
9 files changed
Lines changed: 114 additions & 20 deletions
File tree
- demos/contract-templates
- public
- src
- packages
- document-api/src/content-controls
- super-editor/src/editors/v1
- core/super-converter/v3/handlers/w/sdt/helpers
- document-api-adapters
- helpers/content-controls
- plan-engine
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
| 9 | + | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
14 | | - | |
| 13 | + | |
| 14 | + | |
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | | - | |
36 | | - | |
| 35 | + | |
| 36 | + | |
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
| |||
Binary file not shown.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | | - | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
8 | 10 | | |
9 | 11 | | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
14 | 18 | | |
15 | 19 | | |
16 | 20 | | |
17 | 21 | | |
18 | 22 | | |
19 | 23 | | |
20 | 24 | | |
21 | | - | |
| 25 | + | |
| 26 | + | |
22 | 27 | | |
23 | 28 | | |
24 | 29 | | |
| |||
58 | 63 | | |
59 | 64 | | |
60 | 65 | | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
61 | 69 | | |
62 | 70 | | |
63 | 71 | | |
| |||
276 | 284 | | |
277 | 285 | | |
278 | 286 | | |
279 | | - | |
280 | | - | |
281 | | - | |
282 | | - | |
283 | | - | |
| 287 | + | |
284 | 288 | | |
285 | 289 | | |
286 | 290 | | |
| |||
Lines changed: 9 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
17 | 23 | | |
18 | 24 | | |
| 25 | + | |
19 | 26 | | |
20 | 27 | | |
21 | 28 | | |
| |||
27 | 34 | | |
28 | 35 | | |
29 | 36 | | |
| 37 | + | |
30 | 38 | | |
31 | 39 | | |
32 | 40 | | |
| |||
Lines changed: 13 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
| 11 | + | |
11 | 12 | | |
12 | 13 | | |
13 | 14 | | |
| 15 | + | |
14 | 16 | | |
15 | 17 | | |
16 | 18 | | |
| |||
19 | 21 | | |
20 | 22 | | |
21 | 23 | | |
22 | | - | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
23 | 34 | | |
24 | 35 | | |
25 | 36 | | |
| |||
Lines changed: 66 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
224 | 224 | | |
225 | 225 | | |
226 | 226 | | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
227 | 293 | | |
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| 43 | + | |
43 | 44 | | |
44 | 45 | | |
45 | 46 | | |
| |||
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| 26 | + | |
26 | 27 | | |
27 | 28 | | |
28 | 29 | | |
| |||
Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
626 | 626 | | |
627 | 627 | | |
628 | 628 | | |
| 629 | + | |
629 | 630 | | |
630 | 631 | | |
631 | 632 | | |
| |||
785 | 786 | | |
786 | 787 | | |
787 | 788 | | |
| 789 | + | |
| 790 | + | |
788 | 791 | | |
789 | 792 | | |
790 | 793 | | |
| |||
0 commit comments