fix(run-plugin): narrow accept/reject guard to actually-removed keys (#2786)

The previous fix skipped the SD-2517 lost-keys preservation for every inline
key whenever an accept/reject transaction ran. That was too broad: in imported
docs where explicit w:rPr keys may drop out of computed inline props via
style-equivalence, an unrelated accept/reject on the same run stripped those
keys from runProperties, losing inline formatting on export.

Collect the specific keys removed in this batch instead — mark type name for
standalone marks, and each truthy attr key for removed textStyle marks — and
only block preservation for those keys. Unrelated inline keys on the same run
keep their import-time fallback.

Replaces the blanket !isAcceptReject guard introduced in 4537381.

Co-authored-by: Caio Pizzol <caiopizzol@icloud.com>

Author: caio-pizzol

packages/super-editor/src/editors/v1/extensions/run/calculateInlineRunPropertiesPlugin.js

@@ -51,20 +51,21 @@ export const calculateInlineRunPropertiesPlugin = (editor) =>
       const runType = newState.schema.nodes.run;
       if (!runType) return null;
 
-      // Track-change accept/reject rewrites marks to a canonical state. Inline-key metadata
-      // and run.runProperties from the prior (suggested) state are stale and must not be
-      // re-applied by the SD-2517 lost-keys preservation below.
-      const isAcceptReject = transactions.some((t) => t.getMeta('inputType') === 'acceptReject');
-
-      // Collect mark types the user explicitly removed in this batch — for these, the
-      // lost-keys preservation must NOT re-apply values from stale run.runProperties.
-      // Map textStyle attr-keys to 'textStyle' for comparison.
-      const removedMarkTypes = new Set();
+      // Collect keys the user (or accept/reject) explicitly removed in this batch so the
+      // SD-2517 lost-keys preservation below doesn't re-apply their stale run.runProperties.
+      // - standalone marks (bold, italic, …): the mark's type name is the key.
+      // - textStyle: each truthy attr on the removed mark is a key (fontFamily, color, …).
+      const removedKeys = new Set();
       transactions.forEach((t) => {
         t.steps.forEach((step) => {
           const jsonStep = step.toJSON?.();
-          if (jsonStep?.stepType === 'removeMark' && jsonStep.mark?.type) {
-            removedMarkTypes.add(jsonStep.mark.type);
+          if (jsonStep?.stepType !== 'removeMark' || !jsonStep.mark?.type) return;
+          if (jsonStep.mark.type === 'textStyle') {
+            Object.entries(jsonStep.mark.attrs || {}).forEach(([key, value]) => {
+              if (value != null) removedKeys.add(key);
+            });
+          } else {
+            removedKeys.add(jsonStep.mark.type);
           }
         });
       });
@@ -173,19 +174,17 @@ export const calculateInlineRunPropertiesPlugin = (editor) =>
           // mark round-trip comparison), preserve the original keys. The importer saw
           // explicit w:rPr in the XML and that decision is authoritative. (SD-2517)
           //
-          // Skip entirely during accept/reject: the restored marks are canonical, and
-          // existing run.runProperties still reflect the pre-resolution (suggested) state.
-          if (hadInlineKeys && !isAcceptReject) {
+          // Skip per-key when this batch removed that exact key (toggleItalic off,
+          // reject of a fontFamily suggestion, etc.) — otherwise we'd re-apply a stale
+          // value the user just asked us to drop. Unrelated inline keys on the same run
+          // are left alone so imported w:rPr still survives accept/reject round-trips.
+          if (hadInlineKeys) {
             const computedKeys = new Set(runProperties ? Object.keys(runProperties) : []);
             const lostKeys = existingInlineKeys.filter((k) => !computedKeys.has(k));
             if (lostKeys.length > 0) {
               if (!runProperties) runProperties = {};
               lostKeys.forEach((k) => {
-                // If the user just removed the standalone mark for this key, don't
-                // preserve the stale value from the run node's runProperties.
-                // (For textStyle-derived keys, preserve — the import w:rPr is authoritative
-                // and in-batch textStyle rewrites replace the mark rather than strip a single attr.)
-                if (removedMarkTypes.has(k)) return;
+                if (removedKeys.has(k)) return;
                 if (runNode.attrs?.runProperties?.[k] !== undefined) {
                   runProperties[k] = runNode.attrs.runProperties[k];
                 }