fix(super-editor): skip empty block SDT content selection

Author: luccas-harbour

packages/super-editor/src/editors/v1/core/commands/selectBlockSdtAtTextBlockBoundary.js

@@ -62,6 +62,7 @@ function selectAdjacentBlockSdtContent(direction) {
     const contentStart = findFirstContentCursorPosInNode(node, nodePos);
     const contentEnd = findLastContentCursorPosInNode(node, nodePos);
     if (contentStart == null || contentEnd == null) return false;
+    if (contentStart >= contentEnd) return false;
 
     if (dispatch) {
       dispatch(state.tr.setSelection(TextSelection.create(state.doc, contentStart, contentEnd)).scrollIntoView());

packages/super-editor/src/editors/v1/core/commands/selectBlockSdtAtTextBlockBoundary.test.js

@@ -21,6 +21,7 @@ const makeSchema = () =>
           lockMode: { default: 'unlocked' },
         },
       },
+      mathBlock: { group: 'block', atom: true },
       image: { inline: true, group: 'inline', atom: true },
       text: { group: 'inline' },
     },
@@ -84,6 +85,20 @@ const makeNestedDoc = (schema, lockMode = 'contentLocked') => {
   return schema.node('doc', null, [paragraph(schema, 'Before'), outerSdt, paragraph(schema, 'After')]);
 };
 
+const makeEmptyBlockSdtDoc = (schema) => {
+  const sdt = schema.nodes.structuredContentBlock.create({ lockMode: 'contentLocked' }, [
+    schema.nodes.paragraph.create(),
+  ]);
+  return schema.node('doc', null, [paragraph(schema, 'Before'), sdt, paragraph(schema, 'After')]);
+};
+
+const makeAtomBlockSdtDoc = (schema) => {
+  const sdt = schema.nodes.structuredContentBlock.create({ lockMode: 'contentLocked' }, [
+    schema.nodes.mathBlock.create(),
+  ]);
+  return schema.node('doc', null, [paragraph(schema, 'Before'), sdt, paragraph(schema, 'After')]);
+};
+
 describe('selectBlockSdtBeforeTextBlockStart', () => {
   it.each(['unlocked', 'sdtLocked', 'contentLocked', 'sdtContentLocked'])(
     'selects the previous %s block SDT content from the following textblock start',
@@ -121,6 +136,22 @@ describe('selectBlockSdtBeforeTextBlockStart', () => {
     expect(dispatch).not.toHaveBeenCalled();
   });
 
+  it.each([
+    ['empty paragraph', makeEmptyBlockSdtDoc],
+    ['block atom', makeAtomBlockSdtDoc],
+  ])('returns false for previous block SDT with %s content', (_, makeAdjacentDoc) => {
+    const schema = makeSchema();
+    const doc = makeAdjacentDoc(schema);
+    const afterStart = findTextPos(doc, 'After');
+    const state = EditorState.create({ schema, doc, selection: TextSelection.create(doc, afterStart) });
+    const dispatch = vi.fn();
+
+    const ok = selectBlockSdtBeforeTextBlockStart()({ state, dispatch });
+
+    expect(ok).toBe(false);
+    expect(dispatch).not.toHaveBeenCalled();
+  });
+
   it('selects nested previous block SDT content from the following nested textblock start', () => {
     const schema = makeSchema();
     const doc = makeNestedDoc(schema);
@@ -158,6 +189,22 @@ describe('selectBlockSdtAfterTextBlockEnd', () => {
     },
   );
 
+  it.each([
+    ['empty paragraph', makeEmptyBlockSdtDoc],
+    ['block atom', makeAtomBlockSdtDoc],
+  ])('returns false for next block SDT with %s content', (_, makeAdjacentDoc) => {
+    const schema = makeSchema();
+    const doc = makeAdjacentDoc(schema);
+    const beforeEnd = findTextPos(doc, 'Before', 'Before'.length);
+    const state = EditorState.create({ schema, doc, selection: TextSelection.create(doc, beforeEnd) });
+    const dispatch = vi.fn();
+
+    const ok = selectBlockSdtAfterTextBlockEnd()({ state, dispatch });
+
+    expect(ok).toBe(false);
+    expect(dispatch).not.toHaveBeenCalled();
+  });
+
   it('selects nested next block SDT content from the preceding nested textblock end', () => {
     const schema = makeSchema();
     const doc = makeNestedDoc(schema);