fix: clean up convertTiffToPng signature and add wiring test

- Remove unused Uint8Array/ArrayBufferView branches (only strings are passed)
- Add handleImageNode test verifying convertTiffToPng is called for .tif files

Author: gpardhivvarma

packages/super-editor/src/core/super-converter/v3/handlers/wp/helpers/encode-image-node-helpers.test.js

@@ -2,6 +2,7 @@ import { describe, it, expect, vi, beforeEach } from 'vitest';
 import { handleImageNode, getVectorShape } from './encode-image-node-helpers.js';
 import { emuToPixels, polygonToObj, rotToDegrees } from '@converter/helpers.js';
 import { extractFillColor, extractStrokeColor, extractStrokeWidth, extractLineEnds } from './vector-shape-helpers.js';
+import { convertTiffToPng } from './tiff-converter.js';
 
 vi.mock('@converter/helpers.js', async (importOriginal) => {
   const actual = await importOriginal();
@@ -21,6 +22,14 @@ vi.mock('./vector-shape-helpers.js', () => ({
   extractCustomGeometry: vi.fn(),
 }));
 
+vi.mock('./tiff-converter.js', async (importOriginal) => {
+  const actual = await importOriginal();
+  return {
+    ...actual,
+    convertTiffToPng: vi.fn(actual.convertTiffToPng),
+  };
+});
+
 describe('handleImageNode', () => {
   beforeEach(() => {
     vi.clearAllMocks();
@@ -221,6 +230,20 @@ describe('handleImageNode', () => {
     expect(result.attrs.size).toEqual({ width: 5, height: 6 }); // emuToPixels mocked
   });
 
+  it('calls convertTiffToPng for .tif images', () => {
+    convertTiffToPng.mockReturnValue({ dataUri: 'data:image/png;base64,fake', format: 'png' });
+    const node = makeNode();
+    const params = {
+      ...makeParams('media/photo.tif'),
+      converter: { media: { 'word/media/photo.tif': 'data:image/tiff;base64,AAAA' } },
+    };
+    const result = handleImageNode(node, params, false);
+
+    expect(convertTiffToPng).toHaveBeenCalledWith('data:image/tiff;base64,AAAA');
+    expect(result.attrs.src).toBe('data:image/png;base64,fake');
+    expect(result.attrs.extension).toBe('png');
+  });
+
   it('captures unhandled drawing children for passthrough preservation', () => {
     const node = makeNode();
     node.elements.push({

packages/super-editor/src/core/super-converter/v3/handlers/wp/helpers/tiff-converter.js

@@ -66,23 +66,16 @@ function createCanvas() {
  */
 export function convertTiffToPng(data) {
   try {
+    if (typeof data !== 'string') return null;
+
     // Parse input — accept data URI or raw base64
-    let bytes;
-    if (typeof data === 'string') {
-      let base64 = data;
-      if (data.startsWith('data:')) {
-        const commaIndex = data.indexOf(',');
-        if (commaIndex === -1) return null;
-        base64 = data.substring(commaIndex + 1);
-      }
-      bytes = base64ToUint8Array(base64);
-    } else if (data instanceof Uint8Array) {
-      bytes = data;
-    } else if (ArrayBuffer.isView(data)) {
-      bytes = new Uint8Array(data.buffer, data.byteOffset, data.byteLength);
-    } else {
-      return null;
+    let base64 = data;
+    if (data.startsWith('data:')) {
+      const commaIndex = data.indexOf(',');
+      if (commaIndex === -1) return null;
+      base64 = data.substring(commaIndex + 1);
     }
+    const bytes = base64ToUint8Array(base64);
 
     const buffer = bytes.buffer.slice(bytes.byteOffset, bytes.byteOffset + bytes.byteLength);
 

packages/super-editor/src/core/super-converter/v3/handlers/wp/helpers/tiff-converter.test.js

@@ -83,7 +83,8 @@ describe('tiff-converter', () => {
       const spy = vi.spyOn(document, 'createElement').mockReturnValue(mockCanvas);
 
       return import('./tiff-converter.js?happy').then(({ convertTiffToPng: fn }) => {
-        const result = fn(new Uint8Array([0x49, 0x49, 0x2a, 0x00]));
+        // Pass base64-encoded string (the only input type the call site uses)
+        const result = fn('SU8qAA==');
         expect(result).toEqual({ dataUri: 'data:image/png;base64,iVBORw0KGgo=', format: 'png' });
 
         spy.mockRestore();
@@ -102,7 +103,7 @@ describe('tiff-converter', () => {
 
       // Re-import to pick up the mock
       return import('./tiff-converter.js?oversized').then(({ convertTiffToPng: fn }) => {
-        const result = fn(new Uint8Array([0x49, 0x49, 0x2a, 0x00]));
+        const result = fn('SU8qAA==');
         expect(result).toBeNull();
         vi.doUnmock('utif2');
       });