Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion packages/super-editor/src/components/SuperEditor.vue
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,7 @@ const openPopover = (component, props, position) => {
const tableResizeState = reactive({
visible: false,
tableElement: null,
dragging: false,
});

/**
Expand Down Expand Up @@ -553,6 +554,9 @@ const isNearRowBoundary = (event, tableElement) => {
* @returns {void}
*/
const updateTableResizeOverlay = (event) => {
// Don't change overlay visibility while a resize drag is active
if (tableResizeState.dragging) return;

// Throttle: skip if called too frequently
const now = Date.now();
if (now - lastUpdateTableResizeTimestamp < TABLE_RESIZE_THROTTLE_MS) {
Expand Down Expand Up @@ -594,6 +598,17 @@ const updateTableResizeOverlay = (event) => {
* Hide table resize overlay (on mouse leave)
*/
const hideTableResizeOverlay = () => {
if (tableResizeState.dragging) return;
Comment thread
harbournick marked this conversation as resolved.
tableResizeState.visible = false;
tableResizeState.tableElement = null;
};

const onTableResizeStart = () => {
tableResizeState.dragging = true;
};

const onTableResizeEnd = () => {
tableResizeState.dragging = false;
tableResizeState.visible = false;
tableResizeState.tableElement = null;
};
Expand Down Expand Up @@ -735,7 +750,12 @@ const handleOverlayUpdates = (event) => {
} else {
updateTableResizeOverlay(event);
}
updateImageResizeOverlay(event);
// Don't evaluate image overlay during an active table resize drag —
// without the oversized table overlay, pointer events can reach images
// and spuriously activate the image resize overlay mid-drag.
if (!tableResizeState.dragging) {
updateImageResizeOverlay(event);
}
};

/**
Expand Down Expand Up @@ -1207,6 +1227,8 @@ onBeforeUnmount(() => {
:editor="activeEditor"
:visible="tableResizeState.visible"
:tableElement="tableResizeState.tableElement"
@resize-start="onTableResizeStart"
@resize-end="onTableResizeEnd"
/>
<!-- Image resize overlay for interactive image resizing -->
<ImageResizeOverlay
Expand Down
268 changes: 268 additions & 0 deletions packages/super-editor/src/components/TableResizeOverlay.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -1041,4 +1041,272 @@ describe('TableResizeOverlay', () => {
wrapper.unmount();
});
});

// ==========================================================================
// Visual bounds during drag (SD-2094)
// ==========================================================================

describe('Visual bounds during drag (SD-2094)', () => {
/** Metadata with both column and row boundaries for cross-axis tests */
const metadataWithRows = {
columns: [
{ i: 0, x: 0, w: 100, min: 50, r: 1 },
{ i: 1, x: 100, w: 150, min: 50, r: 1 },
],
rows: [
{ i: 0, y: 0, h: 50, min: 30, r: 1 },
{ i: 1, y: 50, h: 50, min: 30, r: 1 },
],
};

it('should not expand overlay width during column drag', async () => {
const tableElement = createMockTableElement();
const wrapper = mount(TableResizeOverlay, {
props: {
editor: createMockEditor(),
visible: true,
tableElement,
},
});

await nextTick();

// Start a column drag
const event = new MouseEvent('mousedown', { clientX: 100 });
Object.defineProperty(event, 'preventDefault', { value: vi.fn() });
Object.defineProperty(event, 'stopPropagation', { value: vi.fn() });
wrapper.vm.onHandleMouseDown(event, 0);

await nextTick();

// Overlay width should remain at table width (350), not expanded
const style = wrapper.vm.overlayStyle;
expect(style.width).toBe('350px');
expect(style.height).toBe('200px');

wrapper.unmount();
});

it('should not expand overlay height during row drag', async () => {
const tableElement = createMockTableElement(metadataWithRows);
const wrapper = mount(TableResizeOverlay, {
props: {
editor: createMockEditor(),
visible: true,
tableElement,
},
});

await nextTick();

// Start a row drag
const event = new MouseEvent('mousedown', { clientY: 50 });
Object.defineProperty(event, 'preventDefault', { value: vi.fn() });
Object.defineProperty(event, 'stopPropagation', { value: vi.fn() });
wrapper.vm.onRowHandleMouseDown(event, 0);

await nextTick();

// Overlay height should remain at table height (200), not expanded
const style = wrapper.vm.overlayStyle;
expect(style.width).toBe('350px');
expect(style.height).toBe('200px');

wrapper.unmount();
});

it('should constrain row handle width to table width', async () => {
const tableElement = createMockTableElement(metadataWithRows);
const wrapper = mount(TableResizeOverlay, {
props: {
editor: createMockEditor(),
visible: true,
tableElement,
},
});

await nextTick();

const rowBoundary = wrapper.vm.resizableRowBoundaries[0];
const style = wrapper.vm.getRowHandleStyle(rowBoundary);

// Width should be explicit pixel value matching table width, not '100%'
expect(style.width).toBe('350px');

wrapper.unmount();
});

it('should constrain column handle fallback height to table height', async () => {
const tableElement = createMockTableElement();
const wrapper = mount(TableResizeOverlay, {
props: {
editor: createMockEditor(),
visible: true,
tableElement,
},
});

await nextTick();

const boundary = wrapper.vm.resizableBoundaries[0];
// null segment height triggers the fallback
const style = wrapper.vm.getSegmentHandleStyle(boundary, { y: null, h: null });

// Height should be explicit pixel value matching table height, not '100%'
expect(style.height).toBe('200px');

wrapper.unmount();
});

it('should constrain column guideline height to table height during drag', async () => {
const tableElement = createMockTableElement();
const wrapper = mount(TableResizeOverlay, {
props: {
editor: createMockEditor(),
visible: true,
tableElement,
},
});

await nextTick();

const event = new MouseEvent('mousedown', { clientX: 100 });
Object.defineProperty(event, 'preventDefault', { value: vi.fn() });
Object.defineProperty(event, 'stopPropagation', { value: vi.fn() });
wrapper.vm.onHandleMouseDown(event, 0);

await nextTick();

const style = wrapper.vm.guidelineStyle;
expect(style.height).toBe('200px');

wrapper.unmount();
});

it('should constrain row guideline width to table width during drag', async () => {
const tableElement = createMockTableElement(metadataWithRows);
const wrapper = mount(TableResizeOverlay, {
props: {
editor: createMockEditor(),
visible: true,
tableElement,
},
});

await nextTick();

const event = new MouseEvent('mousedown', { clientY: 50 });
Object.defineProperty(event, 'preventDefault', { value: vi.fn() });
Object.defineProperty(event, 'stopPropagation', { value: vi.fn() });
wrapper.vm.onRowHandleMouseDown(event, 0);

await nextTick();

const style = wrapper.vm.rowGuidelineStyle;
expect(style.width).toBe('350px');

wrapper.unmount();
});

it('should hide row handles during column drag', async () => {
const tableElement = createMockTableElement(metadataWithRows);
const wrapper = mount(TableResizeOverlay, {
props: {
editor: createMockEditor(),
visible: true,
tableElement,
},
});

await nextTick();

// Row handles should be visible before drag
const rowHandlesBefore = wrapper.findAll('.resize-handle--row');
expect(rowHandlesBefore.length).toBeGreaterThan(0);
expect(rowHandlesBefore[0].element.style.display).not.toBe('none');

// Start a column drag
const event = new MouseEvent('mousedown', { clientX: 100 });
Object.defineProperty(event, 'preventDefault', { value: vi.fn() });
Object.defineProperty(event, 'stopPropagation', { value: vi.fn() });
wrapper.vm.onHandleMouseDown(event, 0);

await nextTick();

// Row handles should be hidden (v-show sets display:none) during column drag
const rowHandlesDuring = wrapper.findAll('.resize-handle--row');
for (const handle of rowHandlesDuring) {
expect(handle.element.style.display).toBe('none');
}

wrapper.unmount();
});

it('should hide column handles during row drag', async () => {
const tableElement = createMockTableElement(metadataWithRows);
const wrapper = mount(TableResizeOverlay, {
props: {
editor: createMockEditor(),
visible: true,
tableElement,
},
});

await nextTick();

// Column handles should be visible before drag
const colHandlesBefore = wrapper.findAll('.resize-handle:not(.resize-handle--row)');
expect(colHandlesBefore.length).toBeGreaterThan(0);
expect(colHandlesBefore[0].element.style.display).not.toBe('none');

// Start a row drag
const event = new MouseEvent('mousedown', { clientY: 50 });
Object.defineProperty(event, 'preventDefault', { value: vi.fn() });
Object.defineProperty(event, 'stopPropagation', { value: vi.fn() });
wrapper.vm.onRowHandleMouseDown(event, 0);

await nextTick();

// Column handles should be hidden (v-show sets display:none) during row drag
const colHandlesDuring = wrapper.findAll('.resize-handle:not(.resize-handle--row)');
for (const handle of colHandlesDuring) {
expect(handle.element.style.display).toBe('none');
}

wrapper.unmount();
});

it('should always emit resize-end on column drag mouseup', async () => {
const tableElement = createMockTableElement();
const wrapper = mount(TableResizeOverlay, {
props: {
editor: createMockEditor(),
visible: true,
tableElement,
},
});

await nextTick();

// Start drag
const downEvent = new MouseEvent('mousedown', { clientX: 100 });
Object.defineProperty(downEvent, 'preventDefault', { value: vi.fn() });
Object.defineProperty(downEvent, 'stopPropagation', { value: vi.fn() });
wrapper.vm.onHandleMouseDown(downEvent, 0);

expect(wrapper.vm.dragState).not.toBeNull();

// Immediately release (zero delta — below MIN_RESIZE_DELTA_PX)
const upEvent = new MouseEvent('mouseup');
document.dispatchEvent(upEvent);

await nextTick();

// resize-end should still be emitted even with zero delta
expect(wrapper.emitted('resize-end')).toBeDefined();
expect(wrapper.emitted('resize-end').length).toBeGreaterThanOrEqual(1);

wrapper.unmount();
});
});
});
Loading
Loading