Update presentation when typing inside table in sdt#2729
Update presentation when typing inside table in sdt#2729VladaHarbour wants to merge 3 commits intomainfrom
Conversation
superdoc-bot
bot
added
review: thorough
review: careful
and removed
review: thorough
labels
VladaHarbour
force-pushed
the
sd-2453_typing-table-sdt
branch
from
1964a88 to
006066c
Compare
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
@VladaHarbour good fix — the three changes work well together: cache updates so edits show up, version tracking so the page re-renders, and click handling so the cursor lands inside the inner table instead of selecting the whole field.
no correctness issues found.
one thing we noticed while testing: opening a Word file that already has this structure (table inside an SDT inside a table cell) doesn't produce the right nodes on import — the inner tables get dropped. that's not something this PR broke, it was already like that, but it means these code paths only get triggered through the template builder (where users build the structure interactively). could be worth a follow-up ticket for import support.
left two inline comments — both about test coverage, not the logic itself.
| // Nested tables inside table cells must contribute to the parent | ||
| // table cache key, otherwise edits can be missed until a later | ||
| // broader invalidation. | ||
| cellHashes.push(`nt:${hashRuns(cellBlock as FlowBlock)}`); |
There was a problem hiding this comment.
this works but there's no test for it. cache.test.ts already has lots of table tests — adding one for a table-inside-a-table (~30 lines, same pattern) would make sure this path doesn't break silently. worth adding?
| hash = hashString(hash, getRunStringProp(run, 'vertAlign')); | ||
| hash = hashNumber(hash, getRunNumberProp(run, 'baselineShift')); | ||
| } | ||
| } else if (cellBlock?.kind) { |
There was a problem hiding this comment.
this catches all non-paragraph blocks in cells, while cache.ts only catches tables specifically. both approaches work, just different — worth a comment pointing to each other so whoever changes one remembers the other exists.
VladaHarbour
force-pushed
the
sd-2453_typing-table-sdt
branch
from
006066c to
82075ec
Compare
3 participants
No description provided.