Conversation
artem-harbour
force-pushed
the
artem/SD-2509
branch
from
5e09a88 to
28ce971
Compare
|
@harbournick @caio-pizzol - please review and merge. |
…509) Add assertions for changeId, trackedChangeDisplayType, and deletedText null-guards on pure-insertion path. Add Playwright spec for the update-after-replace flow that triggered SD-2509.
…509) The old name read as "deletion then insertion" but actually means "both marks co-exist for the same change id, i.e. a replacement." Every call site had a comment re-explaining this. The rename makes the intent self-evident and retires those comments.
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
@artem-harbour good fix, verified in the dev app.
the bug was that after the first keystroke of a replacement, follow-up keystrokes lost the deleted text because only the insert mark came through in the transaction. your fix catches that correctly.
pushed a few additions to your branch:
- extra assertions on your test + a guard that pure insertions don't accidentally get deleted text
- a playwright spec that reproduces the full bug scenario end-to-end
- renamed
isDeletionInsertion→isReplacement— the old name confused every reader, now it's obvious
|
🎉 This PR is included in @superdoc-dev/react v1.2.0-next.12 The release is available on GitHub release |
|
🎉 This PR is included in vscode-ext v2.3.0-next.15 |
|
🎉 This PR is included in esign v2.3.0-next.15 The release is available on GitHub release |
|
🎉 This PR is included in template-builder v1.5.0-next.15 The release is available on GitHub release |
|
🎉 This PR is included in superdoc v1.26.0-next.15 The release is available on GitHub release |
|
🎉 This PR is included in superdoc-cli v0.7.0-next.16 The release is available on GitHub release |
|
🎉 This PR is included in superdoc-sdk v1.6.0-next.13 |
3 participants
Linear: SD-2509