Feat/upper limit converter Math: implement m:limUpp upper limit converter (community) #2600#2788
Closed
Anuj52 wants to merge 6 commits intosuperdoc-dev:mainfrom
Closed
Feat/upper limit converter Math: implement m:limUpp upper limit converter (community) #2600#2788Anuj52 wants to merge 6 commits intosuperdoc-dev:mainfrom
Anuj52 wants to merge 6 commits intosuperdoc-dev:mainfrom
Conversation
- Dedupe duplicate `m:rad converter` describe block in omml-to-mathml.test.ts - Add unit test for empty <m:deg/> with no <m:degHide> — Word's round-trip canonical form for "no explicit degree". Without the empty-deg check this case produced an invalid <mroot> with an empty index. - Add unit tests for ST_OnOff "on" / "off" variants on m:degHide (ECMA-376 §22.9.2.7) — Word normalizes these on save but other DOCX producers (Google Docs, LibreOffice, Pages) may emit them. - Treat m:degHide val="off" as not hidden — previously interpreted as true. - Restore correct spec citation §22.1.2.88 for m:rad (the prior change to §22.1.2.86 was incorrect; §22.1.2.88 is the rad section in ECMA-376). - Add math-radical-tests.docx behavior fixture (3 cases: canonical sqrt, cube root, empty-deg-no-degHide). - Add behavior tests asserting <msqrt> / <mroot> shape per case and that no <mroot> ever has an empty index.
Add unit tests for m:val="1" (canonical Word output) and m:val="true" (ST_OnOff true alias) so degHide handling for the common true values is locked in, complementing the existing "no val" / "on" / "off" / "0" cases.
Contributor
|
hey @Anuj52, thanks for the follow-up, and congrats on getting #2784 merged yesterday! bad timing on this one though — #2771 landed a few hours ago and already ships both the radical changes and tests in this PR are your own work from #2784 that's already on main — this branch just never got rebased, so they're showing up again. i'd close this one. if you spot any issues with the math equation features that have been landing — bugs, edge cases, rendering problems — please open a PR or file an issue and we'll be happy to take a look. thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implemented the m:limUpp (upper limit) OMML to MathML converter to support rendering math objects with limits positioned above a base expression (e.g., "max" with a limit above).
Changes
Verification Results
Ref: SD-2378
