You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The key change β switching from .some() to .every() in the mc:Choice selection logic β is exactly what ECMA-376 Part 3 Β§10.2.2 requires:
"If the markup consumer does not understand all of the namespaces identified, it shall not select that Choice element. Markup consumers shall select the first Choice element, in markup order, in which all namespaces identified by the Requires attribute are understood."
The old .some() behavior was actually a spec violation: it would select a mc:Choice if even one of its required namespaces was supported, but the spec mandates every listed namespace must be understood before that choice can be selected. The PR corrects this.
The updated tests reflect the spec correctly:
A choice with Requires="wps w14" (both understood) β selected. β
A choice with Requires="wps unknownNs" (one unknown) β falls through to mc:Fallback. β
The utilities.ts/utilities.test.ts hunks in this diff are media path normalization changes unrelated to OOXML element semantics β nothing to flag there from a spec compliance angle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.