Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 70c0816a73
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if (explicitLineBreakRun >= 0) { | ||
| // Explicit break consumed as a line boundary, continue from run after break. | ||
| currentRun = explicitLineBreakRun + 1; | ||
| currentChar = 0; |
There was a problem hiding this comment.
Preserve trailing explicit lineBreak as final blank line
Advancing currentRun to explicitLineBreakRun + 1 immediately consumes the break run, so when a paragraph ends with lineBreak (or with multiple trailing lineBreak runs), the loop exits without emitting the final empty line(s). This regresses trailing manual-break rendering in remeasure paths (e.g., signature blocks or intentional blank lines at paragraph end) because each trailing break should contribute a visible blank line boundary.
Useful? React with 👍 / 👎.
No description provided.