Skip to content

fix: render manual line breaks correctly#2807

Open
VladaHarbour wants to merge 1 commit intomainfrom
sd-2471_line-breaks-issue
Open

fix: render manual line breaks correctly#2807
VladaHarbour wants to merge 1 commit intomainfrom
sd-2471_line-breaks-issue

Conversation

@VladaHarbour
Copy link
Copy Markdown
Contributor

No description provided.

@linear
Copy link
Copy Markdown

linear bot commented Apr 14, 2026

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 70c0816a73

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +1335 to +1338
if (explicitLineBreakRun >= 0) {
// Explicit break consumed as a line boundary, continue from run after break.
currentRun = explicitLineBreakRun + 1;
currentChar = 0;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve trailing explicit lineBreak as final blank line

Advancing currentRun to explicitLineBreakRun + 1 immediately consumes the break run, so when a paragraph ends with lineBreak (or with multiple trailing lineBreak runs), the loop exits without emitting the final empty line(s). This regresses trailing manual-break rendering in remeasure paths (e.g., signature blocks or intentional blank lines at paragraph end) because each trailing break should contribute a visible blank line boundary.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant