SD-2541 - fix: avoid scrolling back when dragging selection#2809
Open
chittolinag wants to merge 3 commits intomainfrom
Open
SD-2541 - fix: avoid scrolling back when dragging selection#2809chittolinag wants to merge 3 commits intomainfrom
chittolinag wants to merge 3 commits intomainfrom
Conversation
superdoc-bot
bot
added
review: thorough
review: careful
and removed
review: thorough
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Drag-selecting past the viewport edge made the page bounce instead of extending the selection because edge auto-scroll and “scroll selection into view” on every
selectionUpdateboth moved the scroll container at once.Proposed solution
While the pointer is dragging text, skip setting and applying the selection scroll-into-view flag so only edge auto-scroll runs; on pointer up, call a small
notifyDragSelectionEndedhook once so the editor can scroll the selection into view after auto-scroll stops. Keyboard selection (e.g. Shift + arrows) is unchanged.