SD-2527 - feat: implement new types of ordered lists by chittolinag · Pull Request #2873 · superdoc-dev/superdoc

chittolinag · 2026-04-20T18:48:48Z

Introducing new types of ordered lists:

number with bracket
uppercase roman
uppercase alpha
lowercase roman
lowercase alpha
alpha with bracket

Even though we supported rendering the styles when opening documents from Word, the user couldn't start a new list using these types.

This PR introduces a dropdown that allows the user to do so.

Note

This PR depends on #2857. Let's merge the other one first.

linear · 2026-04-20T18:48:51Z

SD-2527 Feature: Numbered list additional options

codecov-commenter · 2026-04-20T19:01:08Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 038936be5a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

… (SD-2527) Coverage for the 10 styles this PR introduces (3 bullet + 7 ordered): - Unit: full mapping matrix for markerTextToBulletStyle and numberingInfoToOrderedStyle, plus the BULLET_STYLE_CHARS and ORDERED_LIST_STYLES override branches in numbering-transforms. - Unit: style param threading through toggleList, including the same-style-toggle-off and different-style-create cases. - Unit: headless toolbar deriver values for all 10 styles plus documented null cases (upper-alpha-paren, decimalZero, prefixed). - Unit: registry rename compatibility (legacy toggleBulletList / toggleOrderedList no longer flows through bullet-list/numbered-list). - Behavior: each toggle command produces correct OOXML and locks in current partial-selection style-switch fragmentation behavior. - Visual: fixture spec for sd-2527-list-styles.docx (auto-discovered).

caio-pizzol

hey @chittolinag! nicely scoped :)

i pushed a follow-up (c2685a3) with tests for all 10 styles - unit + behavior + visual, all passing.

three things inline. one more small thing: the bullet menu and the numbered menu return different shapes when you read their state - bullets give you the character (•), numbered gives you the name (decimal-paren). worth lining up.

needs work.

caio-pizzol · 2026-04-28T18:26:02Z

+      role="menuitem"
+      :aria-label="button.ariaLabel"
+      ref="buttonRefs"
+      @keydown.prevent="(event) => handleKeyDown(event, index)"


.prevent blocks every key, so Tab, Escape, and Space all stop working inside the menu. same fix in NumberedStyleButtons.vue:86.

Suggested change

@keydown.prevent="(event) => handleKeyDown(event, index)"

@keydown="(event) => handleKeyDown(event, index)"

then call event.preventDefault() inside the cases the switch handles.

same comment as here: #2857 (comment)

Resolve conflicts between SD-2527 (ordered list styles + abstract-mutation for whole-list restyling) and SD-2526 (bullet style picker + split button). Behavior decisions: - SD-2527's abstract-mutation gate wins for bullet style swaps too: caret in one item now restyles every sibling at the same (numId, ilvl), preserving list identity and continuous numbering. SD-2526's "swap mints a new numId" tests updated to assert the new whole-level semantics. - Kept SD-2526's `bulletStyleLevel` plumbing on `generateNewListDefinition` so the create path still lands the override at the paragraph's existing nesting level when the abstract gate doesn't apply. - Extended the split-button toolbar pattern to the numbered list dropdown for parity with bullets. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

luccas-harbour · 2026-04-30T15:03:10Z

hey @chittolina! I gave this one a quick pass and found these:

When the cursor is at a line that contains a numbered list, the toolbar used to show the numbered list icon with a darker background. I see that this is not the case anymore but it is what Microsoft Word does, might be worth having a look?

Perhaps you could use the segmented button you implemented for bullet lists here too?

I noticed that if I create a numbered list with 2 items and then, while the cursor is in the second item, I deselect the numbered list toolbar button, it removes the numbering from both items and not just from the one where the cursor was (which is Word's behavior)

chittolinag · 2026-05-01T14:04:25Z

hey @chittolina! I gave this one a quick pass and found these:

When the cursor is at a line that contains a numbered list, the toolbar used to show the numbered list icon with a darker background. I see that this is not the case anymore but it is what Microsoft Word does, might be worth having a look?

Perhaps you could use the segmented button you implemented for bullet lists here too?

I noticed that if I create a numbered list with 2 items and then, while the cursor is in the second item, I deselect the numbered list toolbar button, it removes the numbering from both items and not just from the one where the cursor was (which is Word's behavior)

@luccas-harbour , thanks for the feedback. the 1st issue if fixed. the 2nd, I spoke to Missy and we decided to follow this approach:

if the user has an empty selection and changes the list style (or toggles the list off by clicking the left-side action in the segmented button), it will be applied to the entire list (items at the same level).
if the user has a non empty selection and executes the same actions as above, it will be applied inline, ie, only to the selected item.

chittolina added 5 commits April 17, 2026 14:40

feat: implement 2 extra types of bullet lists (square, circle)

91a9878

refactor: code reuse

8137744

refactor: simplified code removing font override

778c18e

chore: small code tweaks

ce505e4

feat: extra ordered list types

a1e6460

superdoc-bot Bot added the review: careful label Apr 20, 2026

chittolinag changed the title ~~SD-2527 - Implement new types of ordered lists~~ SD-2527 - feat: implement new types of ordered lists Apr 20, 2026

chore: small UI tweaks

69b0ccb

Merge branch 'main' into feat/SD-2527

038936b

chittolinag requested review from caio-pizzol and harbournick April 20, 2026 19:43

chittolinag marked this pull request as ready for review April 20, 2026 19:43

chatgpt-codex-connector Bot reviewed Apr 20, 2026

View reviewed changes

Comment thread packages/super-editor/src/editors/v1/extensions/paragraph/paragraph.js Outdated

Comment thread packages/super-editor/src/editors/v1/components/toolbar/BulletStyleButtons.vue

harbournick force-pushed the main branch from 3eb4571 to 5cb9691 Compare April 23, 2026 21:03

missysuperdoc added the priority label Apr 27, 2026

chittolinag and others added 3 commits April 27, 2026 14:58

Merge branch 'main' into feat/SD-2527

f08c63d

chore: removed console log

c66b595

caio-pizzol requested changes Apr 28, 2026

View reviewed changes

chittolina added 2 commits April 29, 2026 16:48

fix: apply style change to entire list's level

20b0ef4

refactor: simplify logic

e9621f8

chittolinag requested a review from a team as a code owner April 29, 2026 20:19

chittolina and others added 3 commits April 29, 2026 21:53

feat: added upper alpha paren list style

73ce70f

refactor: simplify code

48d9d1e

chittolinag requested a review from luccas-harbour April 30, 2026 13:54

fix: highlight list buttons in toolbar based on cursor position

1cf19ae

harbournick assigned chittolinag and caio-pizzol Apr 30, 2026

feat: apply inline list style when selection is not empty

015bb61

fix: cmd + Z not undoing list style changes

517a95f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SD-2527 - feat: implement new types of ordered lists#2873

SD-2527 - feat: implement new types of ordered lists#2873
chittolinag wants to merge 18 commits intomainfrom
feat/SD-2527

chittolinag commented Apr 20, 2026 •

edited

Loading

Uh oh!

linear Bot commented Apr 20, 2026

Uh oh!

codecov-commenter commented Apr 20, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Uh oh!

caio-pizzol left a comment

Uh oh!

caio-pizzol Apr 28, 2026

Uh oh!

chittolinag Apr 29, 2026

Uh oh!

Uh oh!

Uh oh!

luccas-harbour commented Apr 30, 2026 •

edited

Loading

Uh oh!

chittolinag commented May 1, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

	@keydown.prevent="(event) => handleKeyDown(event, index)"
	@keydown="(event) => handleKeyDown(event, index)"

Conversation

chittolinag commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linear Bot commented Apr 20, 2026

Uh oh!

codecov-commenter commented Apr 20, 2026

Codecov Report

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

caio-pizzol left a comment

Choose a reason for hiding this comment

Uh oh!

caio-pizzol Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

chittolinag Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

luccas-harbour commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chittolinag commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

chittolinag commented Apr 20, 2026 •

edited

Loading

luccas-harbour commented Apr 30, 2026 •

edited

Loading

chittolinag commented May 1, 2026 •

edited

Loading