Conversation
|
Status: FAIL The OOXML-relevant change is the new
const ST_ON_OFF_TRUE_VALUES = new Set(['1', 'true', 'on']);Per ECMA-376 §22.9.2.7, The Everything else about the implementation is correct:
More detail: https://ooxml.dev/spec?q=evenAndOddHeaders | https://ooxml.dev/spec?q=ST_OnOff |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aa6cc40e8b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| <<<<<<< HEAD | ||
| page.columns = { count: activeColumns.count, gap: activeColumns.gap, withSeparator: activeColumns.withSeparator }; | ||
| ======= |
There was a problem hiding this comment.
Resolve merge conflict markers before committing
This file still contains unresolved merge markers (<<<<<<<, =======, >>>>>>>), which makes the TypeScript source unparsable and blocks builds/tests for this package. Because these markers appear in committed source (not just comments), any CI job that compiles layout-engine will fail until the conflict is manually resolved and only one branch’s code remains.
Useful? React with 👍 / 👎.
Summary
Merges latest stable patches into main. Has merge conflicts that need manual resolution.
Release artifact conflicts were auto-resolved, but other conflicts remain.
Auto-created by sync-patches workflow.