Skip to content

πŸ”„ Sync stable β†’ main#2887

Closed
superdoc-bot[bot] wants to merge 1 commit intomainfrom
sync/stable-to-main-20260421-234815
Closed

πŸ”„ Sync stable β†’ main#2887
superdoc-bot[bot] wants to merge 1 commit intomainfrom
sync/stable-to-main-20260421-234815

Conversation

@superdoc-bot
Copy link
Copy Markdown
Contributor

@superdoc-bot superdoc-bot Bot commented Apr 21, 2026

Summary

Merges latest stable patches into main to keep branches in sync.

This ensures @next prereleases stay ahead of @latest releases.


Auto-created by sync-patches workflow.

@github-actions
Copy link
Copy Markdown
Contributor

Status: PASS

The OOXML-relevant change here is the new isStOnOffEnabled helper for w:evenAndOddHeaders in docxImporter.js. The spec details from the search confirm the implementation is correct.

w:evenAndOddHeaders (Β§17.10.1) uses the CT_OnOff complex type (Β§17.17.4), which takes an optional w:val of type ST_OnOff. The spec is explicit: when the element is present but w:val is omitted, the value defaults to true; when the element itself is absent, it defaults to false. The new code gets both of these right.

For ST_OnOff (Β§22.9.2.7), the prose spec only enumerates 1/true (on) and 0/false (off) β€” it describes the type as a restriction of XSD boolean. The 'on' and 'off' strings in ST_ON_OFF_TRUE_VALUES aren't mentioned in the prose spec. That said, the actual OOXML XML Schema defines ST_OnOff as a union that does include on/off strings, and these values appear in real-world documents from older Office versions. Accepting them as a lenient reader is a reasonable pragmatic call, not a violation. See https://ooxml.dev/spec?q=ST_OnOff for the type definition.

Everything else in the diff (layout engine column widths, React onTransaction callback, version bumps) has no OOXML semantics to check.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

βœ… All modified and coverable lines are covered by tests.

πŸ“’ Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch-sync Patch sync from release branch review: careful

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants