You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The OOXML-relevant change here is the new isStOnOffEnabled helper for w:evenAndOddHeaders in docxImporter.js. The spec details from the search confirm the implementation is correct.
w:evenAndOddHeaders (Β§17.10.1) uses the CT_OnOff complex type (Β§17.17.4), which takes an optional w:val of type ST_OnOff. The spec is explicit: when the element is present but w:val is omitted, the value defaults to true; when the element itself is absent, it defaults to false. The new code gets both of these right.
For ST_OnOff (Β§22.9.2.7), the prose spec only enumerates 1/true (on) and 0/false (off) β it describes the type as a restriction of XSD boolean. The 'on' and 'off' strings in ST_ON_OFF_TRUE_VALUES aren't mentioned in the prose spec. That said, the actual OOXML XML Schema defines ST_OnOff as a union that does include on/off strings, and these values appear in real-world documents from older Office versions. Accepting them as a lenient reader is a reasonable pragmatic call, not a violation. See https://ooxml.dev/spec?q=ST_OnOff for the type definition.
Everything else in the diff (layout engine column widths, React onTransaction callback, version bumps) has no OOXML semantics to check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Merges latest stable patches into main to keep branches in sync.
This ensures
@nextprereleases stay ahead of@latestreleases.Auto-created by sync-patches workflow.