refactor(ui): drop ui.review, add ui.trackChanges (SD-2667)#3030
Merged
caio-pizzol merged 1 commit intostablefrom Apr 30, 2026
Merged
refactor(ui): drop ui.review, add ui.trackChanges (SD-2667)#3030caio-pizzol merged 1 commit intostablefrom
caio-pizzol merged 1 commit intostablefrom
Conversation
`ui.review` shipped a merged comments + tracked-changes feed with `accept` / `reject` verbs, but the merged-feed concept was speculative. No customer asked for it, and consumers building review sidebars can compose `ui.comments.items` and `ui.trackChanges.items` themselves (roughly 30 LOC, demonstrated in the BYO-UI demo's ActivitySidebar). Mirroring `editor.doc.trackChanges` keeps the controller surface tight and the layering predictable: each `ui.<domain>` namespace tracks one doc-API namespace. - `TrackChangesItem` carries only tracked changes (no `kind` discriminator) - `TrackChangesSlice` exposes `items` / `total` / `activeId` - `TrackChangesHandle` keeps `accept` / `reject` / `acceptAll` / `rejectAll` / `next` / `previous` / `scrollTo` - `useSuperDocReview` becomes `useSuperDocTrackChanges` - Demo's ActivitySidebar merges the two slices locally
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
|
🎉 This PR is included in superdoc v1.30.1 The release is available on GitHub release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #3029 onto
stableso the publicsuperdoc/uisurface stays aligned across release channels.ui.reviewwas just shipping; releasingstablewith that name whilemaincalls itui.trackChangeswould split the type names across consumers tracking each branch.Picks the rename only. Conflicts resolved by keeping stable's existing surface where it diverges from main (no
ui.documenthandle on stable yet, nobehavior/blockoptions onpresentation.navigateTohere, no BYO-UI demo on stable). The behavioral change is identical to #3029:ui.reviewremoved,ui.trackChangesadded withaccept/reject/acceptAll/rejectAll/next/previous/scrollTo,useSuperDocReviewbecomesuseSuperDocTrackChanges.Verified: 136/136 super-editor UI tests pass on this branch;
superdocbuild clean.Related: #3029 (merged into main).