Skip to content

fix(ui): document useSuperDocTrackChanges return shape#3032

Merged
caio-pizzol merged 1 commit intostablefrom
caio/sd-2667-ui-track-changes-doc-fix
Apr 30, 2026
Merged

fix(ui): document useSuperDocTrackChanges return shape#3032
caio-pizzol merged 1 commit intostablefrom
caio/sd-2667-ui-track-changes-doc-fix

Conversation

@caio-pizzol
Copy link
Copy Markdown
Contributor

The new hook's JSDoc only said "tracked-changes feed". Match the companion useSuperDocComments JSDoc style and spell out the slice fields so consumers know what comes back without diving into the type.

The motivation is also to land #3030's ui.reviewui.trackChanges rename in a published version. The rename was a refactor: commit, which the release pipeline correctly classifies as no-release. This fix: rides along so the rename ships in the next patch.

Cherry-pick onto main once merged.

JSDoc on the new hook only said 'tracked-changes feed'. The
companion useSuperDocComments JSDoc spells out '(items, activeIds,
total)' so consumers know what they get back without diving into
the type. Match that shape: '(items, total, activeId)'.
@caio-pizzol caio-pizzol requested a review from a team as a code owner April 30, 2026 21:25
@linear
Copy link
Copy Markdown

linear Bot commented Apr 30, 2026

@caio-pizzol caio-pizzol merged commit 72c5af9 into stable Apr 30, 2026
11 of 12 checks passed
@caio-pizzol caio-pizzol deleted the caio/sd-2667-ui-track-changes-doc-fix branch April 30, 2026 21:26
@superdoc-bot
Copy link
Copy Markdown
Contributor

superdoc-bot Bot commented Apr 30, 2026

🎉 This PR is included in superdoc v1.30.1

The release is available on GitHub release

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

caio-pizzol added a commit that referenced this pull request May 1, 2026
Resolves 3 conflicts:
- .github/workflows/pr-renderer-build.yml: keep main's new Wait/Write renderer steps
- packages/super-editor/src/ui/create-super-doc-ui.ts: keep main's expanded return (adds document)
- packages/super-editor/src/ui/react/hooks.ts: import DocumentSlice from main; keep stable's docstring fix from PR #3032 for useSuperDocTrackChanges
@superdoc-bot
Copy link
Copy Markdown
Contributor

superdoc-bot Bot commented May 1, 2026

🎉 This PR is included in superdoc-cli v0.8.0

The release is available on GitHub release

@superdoc-bot
Copy link
Copy Markdown
Contributor

superdoc-bot Bot commented May 1, 2026

🎉 This PR is included in superdoc-sdk v1.8.0

@superdoc-bot
Copy link
Copy Markdown
Contributor

superdoc-bot Bot commented May 1, 2026

🎉 This PR is included in @superdoc-dev/mcp v0.3.0

The release is available on GitHub release

@superdoc-bot
Copy link
Copy Markdown
Contributor

superdoc-bot Bot commented May 5, 2026

🎉 This PR is included in vscode-ext v2.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants