[3/3] test(painter): lock ResolvedLayout-only boundary (SD-2836)#3118
Open
tupizz wants to merge 3 commits intotadeu/sd-2836-2-collapse-legacy-apifrom
Open
[3/3] test(painter): lock ResolvedLayout-only boundary (SD-2836)#3118tupizz wants to merge 3 commits intotadeu/sd-2836-2-collapse-legacy-apifrom
tupizz wants to merge 3 commits intotadeu/sd-2836-2-collapse-legacy-apifrom
Conversation
superdoc-bot
Bot
added
review: thorough
review: quick
and removed
review: thorough
labels
This was referenced May 4, 2026
tupizz
force-pushed
the
tadeu/sd-2836-2-collapse-legacy-api
branch
from
6b0c46d to
befe9c0
Compare
tupizz
force-pushed
the
tadeu/sd-2836-3-lock-boundary
branch
from
2fc4758 to
c2370fb
Compare
tupizz
force-pushed
the
tadeu/sd-2836-2-collapse-legacy-api
branch
from
befe9c0 to
8f18041
Compare
tupizz
force-pushed
the
tadeu/sd-2836-3-lock-boundary
branch
from
c2370fb to
34b7e7d
Compare
renderer.ts: drop unused Layout, Page, Measure, FlowBlock, ParagraphBorder type imports left over from the migration. index.test.ts: delete the skipped 'decoration item synthesis' describe block (it was protecting the synthesis path that has been removed).
tupizz
force-pushed
the
tadeu/sd-2836-2-collapse-legacy-api
branch
from
8f18041 to
1c869c1
Compare
tupizz
force-pushed
the
tadeu/sd-2836-3-lock-boundary
branch
from
34b7e7d to
85bd281
Compare
…me dep (SD-2836) Moves @superdoc/layout-resolved to devDependencies in the lockfile to match package.json, so CI's --frozen-lockfile install matches. Boundary tests still need it under devDependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
What changed
Locks the boundary established by PR1+PR2 so no future change can re-introduce legacy painter inputs or disallowed cross-package imports.
Architecture guard
tests/architecture-boundaries.test.ts(Guard D) forbidpainter-domfrom importingpm-adapter,layout-bridge, orlayout-resolvedat runtime.painters/dom/src/contract-shape.test.tspins the painter's public input/option types toResolvedLayoutviaEqual<X, Y>+expectTypeOf. Any drift in the contract fails the suite.Cleanup
@superdoc/layout-resolvedfrompainters/dom/package.jsonruntimedependencies(kept underdevDependenciesfor the boundary tests).Why this split
The painter is now structurally dumb (PR1) and surface-collapsed (PR2). This PR makes that state ratchet-only: regressing the boundary breaks the build, not just review.
Verification
painter-dom,pm-adapter,layout-bridge,layout-engine,super-editor.Test plan
@superdoc/layout-resolvedinpainter-dom