fix: invalid css (SD-2930)#3121
Merged
caio-pizzol merged 1 commit intostablefrom May 4, 2026
Merged
Conversation
Co-authored-by: Artem Nistuley <artem@superdoc.dev>
Contributor
|
🎉 This PR is included in superdoc-cli v0.8.1 The release is available on GitHub release |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
|
🎉 This PR is included in superdoc-sdk v1.8.1 |
Contributor
|
🎉 This PR is included in @superdoc-dev/mcp v0.3.1 The release is available on GitHub release |
Contributor
|
🎉 This PR is included in superdoc v1.31.1 The release is available on GitHub release |
Contributor
|
🎉 This PR is included in vscode-ext v2.3.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #3115 to stable. The published
style.csscontains spec-invalid:where(*:not(svg):not(svg *)::before)selectors. Pseudo-elements aren't valid inside:where(), so when consumer bundlers run the CSS through Lightning CSS, the minifier strips them and emits empty:where()blocks that fail sass-loader.Moves
::before/::afteroutside:where()to produce valid, minifiable CSS. One-line behavioral note: the original selector silently never matched anything in any browser (spec-invalid), so the isolation reset now actually applies to pseudo-elements for the first time. That's the original intent.Verified: lightningcss-cli on the source before the fix → two empty
:where()selectors; after the fix → valid:where(...)::before/::afteroutput.