fix(ui): re-export PublicToolbarItemId from superdoc/ui (SD-2920)#3135
Merged
caio-pizzol merged 1 commit intomainfrom May 5, 2026
Merged
fix(ui): re-export PublicToolbarItemId from superdoc/ui (SD-2920)#3135caio-pizzol merged 1 commit intomainfrom
caio-pizzol merged 1 commit intomainfrom
Conversation
The toolbar-and-commands docs page (apps/docs/editor/custom-ui/
toolbar-and-commands.mdx) tells consumers to import PublicToolbarItemId
from superdoc/ui as the typed source of truth for command ids. SD-2920
shipped BUILT_IN_COMMAND_IDS at runtime through that path but never
re-exported the derived type, so consumers writing
`import type { PublicToolbarItemId } from 'superdoc/ui'` couldn't
actually find it from the documented entry. They had to dip into
superdoc/headless-toolbar instead.
skipLibCheck: true on most consumer tsconfigs masked the broken
re-export from typecheck signal. The dist now exposes the type
through the same barrel as BUILT_IN_COMMAND_IDS, matching what the
docs already promise.
This was referenced May 5, 2026
Contributor
|
🎉 This PR is included in @superdoc-dev/mcp v0.3.0-next.42 The release is available on GitHub release |
Contributor
|
🎉 This PR is included in vscode-ext v2.3.0-next.86 |
Contributor
|
🎉 This PR is included in @superdoc-dev/react v1.2.0-next.84 The release is available on GitHub release |
Contributor
|
🎉 This PR is included in superdoc v1.30.0-next.43 The release is available on GitHub release |
Contributor
|
🎉 This PR is included in superdoc-cli v0.8.0-next.60 The release is available on GitHub release |
Contributor
|
🎉 This PR is included in superdoc-sdk v1.8.0-next.45 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Custom UI toolbar-and-commands docs page tells consumers to import `PublicToolbarItemId` from `superdoc/ui` as the typed source of truth for command ids. SD-2920 shipped `BUILT_IN_COMMAND_IDS` at runtime through that path but never re-exported the derived type, so consumers writing the documented import couldn't actually find it from `superdoc/ui`.
`skipLibCheck: true` on most consumer tsconfigs masked the broken re-export from the typecheck signal. The dist now exposes the type through the same barrel as `BUILT_IN_COMMAND_IDS`, matching what the docs already promise.