Skip to content

feat: rtl for lists#3160

Closed
artem-harbour wants to merge 2 commits intomainfrom
artem/rtl-v2
Closed

feat: rtl for lists#3160
artem-harbour wants to merge 2 commits intomainfrom
artem/rtl-v2

Conversation

@artem-harbour
Copy link
Copy Markdown
Contributor

@artem-harbour artem-harbour commented May 5, 2026

Linear: SD-2932

  • Implemented Phase 4 RTL list fixes in the layout pipeline:
    • Added logical indent normalization in pm-adapter (start/end -> physical sides) and applied RTL mirroring via mirrorIndentForRtl().
    • Fixed RTL list marker anchoring/nesting behavior in rendering paths (including deeper ordered levels).
  • Refactored duplicated marker-indent math:
    • Introduced shared helper resolveMarkerIndent() in shared/common/list-marker-utils.ts.
    • Reused it in both legacy painter path (renderer.ts) and resolved path (resolveParagraph.ts).
  • Added/extended RTL list behavior coverage:
    • Nested RTL list visual levels.
    • Tab/Shift+Tab level changes in RTL lists.
    • ArrowLeft/ArrowRight and Shift+Arrow selection behavior inside RTL list lines.
  • Cleanup:
    • Removed dead ensureBidiIndentPx helper and related public export/tests noise.
  • Documentation/plan updates:
    • Marked changeListLevel inline-indent deletion as non-blocking for validated RTL list scenarios.
    • Marked ParagraphNodeView marker-path item as out of scope for user-facing rendering (DomPainter is the visual path).

Screenshot 1:
Screenshot_1

Screenshot 2:
Screenshot_2

Screenshot 3:
Screenshot_3

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@caio-pizzol caio-pizzol self-assigned this May 5, 2026
@artem-harbour artem-harbour added the don't merge Don't merge yet label May 5, 2026
@linear
Copy link
Copy Markdown

linear Bot commented May 6, 2026

@artem-harbour
Copy link
Copy Markdown
Contributor Author

New PR
#3187

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants