fix: document render crashes#3170
Conversation
superdoc-bot
Bot
added
review: thorough
review: careful
and removed
review: thorough
labels
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8c4ea2a823
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if (kind && Number.isFinite(fragmentHeight) && fragmentHeight >= canvasHeight) { | ||
| return true; |
There was a problem hiding this comment.
This new guard drops all anchored header/footer fragments when fragmentHeight >= canvasHeight, even when the anchor is paragraph-relative and represents real header/footer content rather than a background overlay. In those cases layoutHeaderFooter() now underestimates layout.height, so layoutDocument() reserves too little margin and body content can overlap header/footer content. The exclusion should be tied to true page-covering conditions (anchor mode/position/bounds), not height alone.
Useful? React with 👍 / 👎.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
3 participants
No description provided.