SD-2875 - fix: context menu not showing suggestions after typecheck#3174
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
@chittolinag lgtm :)
left two optional notes inline - skip if you'd rather move on.
Co-authored-by: Caio Pizzol <97641911+caio-pizzol@users.noreply.github.com>
Co-authored-by: Caio Pizzol <97641911+caio-pizzol@users.noreply.github.com>
chittolinag
deleted the
gabriel/sd-2875-bug-spellcheck-suggestions-missing-from-context-menu-in-129
branch
|
🎉 This PR is included in @superdoc-dev/mcp v0.3.0-next.62 The release is available on GitHub release |
|
🎉 This PR is included in @superdoc-dev/react v1.2.0-next.104 The release is available on GitHub release |
|
🎉 This PR is included in vscode-ext v2.3.0-next.106 |
|
🎉 This PR is included in superdoc-cli v0.8.0-next.78 The release is available on GitHub release |
|
🎉 This PR is included in superdoc v1.30.0-next.60 The release is available on GitHub release |
|
🎉 This PR is included in superdoc-sdk v1.8.0-next.60 |
|
🎉 This PR is included in superdoc-cli v0.9.0 The release is available on GitHub release |
|
🎉 This PR is included in superdoc v1.32.0 The release is available on GitHub release |
|
🎉 This PR is included in @superdoc-dev/mcp v0.4.0 The release is available on GitHub release |
|
🎉 This PR is included in @superdoc-dev/react v1.3.0 The release is available on GitHub release |
|
🎉 This PR is included in vscode-ext v2.4.0 |
5 participants
Issue
<ContextMenu>was rebound from the innerEditorto thePresentationEditorwrapper.resolveProofingContextonly looked upeditor._presentationEditor, which the wrapper doesn't have — so it returnednulland the menu dropped every suggestion.Proposed solution
resolveProofingContext(context-menu/utils.js), resolve the manager from any of the three editor handles the menu can be wired to:_presentationEditor.proofingManagerpresentationEditor.proofingManagerproofingManagerBehavior tests
tests/behavior/tests/slash-menu/proofing-context-menu.spec.ts:teh, asserts the suggestions appear and clickingtherewrites the doc.proofing-replace-*rows appear when there's no issue at the cursor.