test(behavior): pin RTL bidiVisual derived from a table style (SD-2767 Wave 3)#3350
Merged
Merged
Conversation
SD-2767 Wave 3 coverage gap. The existing rtl-bidivisual-* fixtures all set w:bidiVisual inline on the table. Style-cascade-derived bidiVisual (a custom table style that sets w:bidiVisual, with the table referencing the style via w:tblStyle and no inline override) was not exercised at the behavior layer. Add a Word-native fixture where: - styles.xml defines RtlStyleTable with w:tblPr/w:bidiVisual - document.xml's table uses w:tblStyle="RtlStyleTable", no inline w:bidiVisual Word confirms Document.Tables(1).TableDirection === 1 (wdTableDirectionRtl) when opening this fixture. The behavior spec asserts cell ordering: logical cells A, B, C in document order must render visually as C, B, A (logical first on visual right). Validates the full pipeline: - pm-adapter style cascade resolves w:bidiVisual from the style (SD-3138 Phase 1B foundation) - DomPainter mirrors visual sides once at paint time Passes on chromium, firefox, webkit. Pure test addition - no production code changes. Future regressions in pm-adapter style resolution or painter mirror logic for style-cascade bidiVisual will fail this test.
caio-pizzol
force-pushed
the
caio-pizzol/SD-2767-wave3-style-bidivisual
branch
from
79d8daf to
bf77bfe
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
msviderok
pushed a commit
to msviderok/superdoc
that referenced
this pull request
May 17, 2026
…e cascade (SD-3171) Update the rtl-style-derived-bidivisual.spec.ts assertion from C B A to A B C - the Word-parity contract that the pm-adapter fix in the previous commit installs. The original assertion in PR superdoc-dev#3350 pinned SuperDoc's pre-fix behavior, not Word's. Add rtl-inline-bidivisual.spec.ts as the positive control: a fixture where w:bidiVisual is set INLINE on the table's tblPr. Word's renderer visually flips cells here (TableDirection=wdTableDirectionRtl, cells render C B A). SuperDoc must match. Both fixtures load a 1x3 table with logical cells A B C. The pair proves the fix is direction-specific: - style-cascade source -> no visual flip (Word-parity, both render A B C) - inline source -> visual flip (Word-parity, both render C B A) Both specs pass on chromium, firefox, webkit. Inline fixture includes the default TableNormal style so the super- converter can anchor its style cascade; the bare custom style version without TableNormal triggered a docxImporter throw.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wave 3 coverage gap on SD-2767. The existing
rtl-bidivisual-*fixtures all setw:bidiVisualinline on the table element. Style-cascade-derivedbidiVisual(a custom table style that sets it, table references viaw:tblStylewith no inline override) was not exercised at the behavior layer.What lands
tests/behavior/tests/tables/fixtures/rtl-style-derived-bidivisual.docx: minimal DOCX fixture, verified in Word.styles.xmldefinesRtlStyleTablewithw:tblPr/w:bidiVisual.document.xmlhas a 1x3 table that usesw:tblStyle="RtlStyleTable"and no inlinew:bidiVisual. Word confirmsDocument.Tables(1).TableDirection === 1(wdTableDirectionRtl) when opening it.tests/behavior/tests/tables/rtl-style-derived-bidivisual.spec.ts: behavior spec asserting cell ordering. Logical cells A, B, C in document order must render visually as C, B, A (logical first on visual right).Pipeline coverage
This validates the full chain:
w:bidiVisualfrom the style (SD-3138 Phase 1B foundation)The test passes on chromium, firefox, webkit. SuperDoc already handles this correctly; the spec is regression coverage against future changes to pm-adapter style resolution or painter mirror logic for style-cascade
bidiVisual.Pure test addition. No production code changes.