feat: add per-author tracked change colors#3559
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1817c5f6c5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
cubic analysis
2 issues found across 30 files
Linked issue analysis
Linked issue: IT-1112: Per-author tracked change colors
| Status | Acceptance criteria | Notes |
|---|---|---|
| ✅ | Expose host config modules.trackChanges.authorColors (enabled/overrides/resolve) so hosts can specify per-author colors | Config shape added across public types/docs and composeAuthorColorResolver re-exported for SuperDoc to build the resolver from host config. |
| ✅ | Compose a resolver honoring overrides (email first, then name), optional resolve callback, and a deterministic fallback color | composeAuthorColorResolver implements overrides → resolve → fallback order; fallbackAuthorColor provides deterministic palette; tests cover override lookup, fallback stability, and host-resolver exceptions. |
| ✅ | Stamp a paint-ready color (TrackedChangeMeta.color) on every tracked-change layer during adapter conversion so the painter need not call host callbacks | stampTrackedChangeColors is implemented and invoked in the pm-adapter before paint, stamping or clearing meta.color based on the resolver. |
| ✅ | Painter applies per-author CSS variable families (--sd-tracked-changes-*) for insert/delete/format layers and derives translucent backgrounds from the base color | Dom painter applies CSS variables from meta.color per layer kind and derives alpha variants; tests assert the variables are set. |
| ✅ | UI snapshot exposes per-item authorColor and an ordered authors list with resolved colors so review UIs can render a legend consistent with painted colors | createSuperDocUI composes the resolver, populates items with authorColor and an authors list, types and tests were updated to expect these fields. |
| ✅ | Disabling or omitting the feature clears stale colors from cached blocks and leaves default palette behavior intact | stampTrackedChangeColors accepts undefined to clear colors; composeAuthorColorResolver returns undefined when config disabled, and adapter only stamps when resolver provided. |
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.