fix(superdoc): resolve @superdoc/font-system in the dev server#3624
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pnpm devcouldn't boot the playground: Vite failed to resolve@superdoc/font-system, so the editor never mounted. That package lives undershared/, which the workspace alias helper (vite.sourceResolve) only maps forpackages/**. The font-system imports were added recently and only the Vitest and CDN configs aliased it; the dev server (command === 'serve') was missed.isDev, so the dev server resolves it fromshared/font-system/src.getAliasesand gated onisDev, so the vite-plugin-dts build is unaffected (an alias there emits unresolvable source paths).Verified:
pnpm devboots on :9094, the editor mounts, and the SD-3330 fixture renders. This was a hard Vite resolution failure before the alias.