Skip to content

fix: prevent focus stealing from external contenteditable editors #3625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattConnHarbour wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: prevent focus stealing from external contenteditable editors #3625

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ...ges/super-editor/src/editors/v1/core/presentation-editor/input/PresentationInputBridge.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,18 @@ export class PresentationInputBridge {
: originNode?.parentElement instanceof HTMLElement
? originNode.parentElement
: null;

// Skip events from external contenteditable elements (e.g., other TipTap/ProseMirror editors).
// If the event target is in a contenteditable that's not part of our editor, don't intercept.
const originContentEditable = originElement?.closest?.('[contenteditable="true"]') as HTMLElement | null;
if (originContentEditable) {
const targetDom = this.#getTargetDom?.();
const targetRoot = targetDom?.closest?.('.presentation-editor') ?? targetDom?.parentElement;
if (targetRoot && !targetRoot.contains(originContentEditable)) {
return null;
Comment on lines +307 to +310
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Do not exclude SuperDoc's sibling hidden editors

When the active target is a header/footer or note story editor, its ProseMirror DOM lives in a hidden host appended under document.body, while the stale body editor is in a different hidden host sibling. In that real setup targetDom.closest('.presentation-editor') is null and the fallback targetDom.parentElement is only the active hidden host, so this check treats the stale SuperDoc editor as “external” and returns before rerouting. That breaks the stale-focus handoff this method exists for, letting input continue into the wrong hidden editor instead of the active story surface.

Useful? React with 👍 / 👎.

}
}

const staleEditorTarget = originElement?.closest?.('.ProseMirror[contenteditable="true"]') as HTMLElement | null;

if (!staleEditorTarget || staleEditorTarget === activeTarget) {
Expand Down
Loading