Merged
Conversation
artem-harbour
commented
Mar 24, 2025
| this.config = { ...this.config, ...config }; | ||
| this.toolbarItems = []; | ||
| this.overflowItems = []; | ||
| this.documentMode = 'editing'; |
Contributor
Author
There was a problem hiding this comment.
The document mode was set to 'editing' and never changed.
Contributor
Author
There was a problem hiding this comment.
But since the document mode is checked on toolbar state update, I can assume that it should change (on doc mode change).
artem-harbour
commented
Mar 24, 2025
| if (editor) editor.setDocumentMode('editing'); | ||
| }); | ||
|
|
||
| if (this.toolbar) { |
Contributor
Author
There was a problem hiding this comment.
Set document mode for toolbar and update the state.
artem-harbour
commented
Mar 24, 2025
|
|
||
| this.toolbar = new SuperToolbar(config); | ||
| this.toolbar.on('superdoc-command', this.onToolbarCommand.bind(this)); | ||
| this.once('editorCreate', () => this.toolbar.updateToolbarState()); |
Contributor
Author
There was a problem hiding this comment.
We need to wait for the editor to be created to update the toolbar state because there are a lot of asynchronous things behind.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed updating the toolbar state when initialized and when updating the document mode.
@harbournick Please double check before merging as I'm not aware of the details of
SuperToolbarandSuperDocclasses.