Skip to content

Comments plugin fixes#413

Merged
edoversb merged 2 commits intomainfrom
nick/floating-comments2
Mar 24, 2025
Merged

Comments plugin fixes#413
edoversb merged 2 commits intomainfrom
nick/floating-comments2

Conversation

@harbournick
Copy link
Copy Markdown
Collaborator

@harbournick harbournick commented Mar 24, 2025 •
edited
Loading

  • fix comment import
  • removes importedId at import, assigns commentId from import
  • fix comment export for importedAuthor
  • fix setting active comment ID in comments plugin

@harbournick
Fixes comments import, replaces importedId with commentId, fixes shou…
ff83a07 
…ldUpdate in comments plugin, fixes updating active id in comments plugin
@harbournick
Fix author for comment export
26bcb32
@harbournick harbournick self-assigned this Mar 24, 2025
@harbournick harbournick changed the title Fixes comments import, replaces importedId with commentId, fixes shou… Comments plugin fixes Mar 24, 2025
@harbournick harbournick marked this pull request as ready for review March 24, 2025 16:36
@harbournick harbournick requested a review from edoversb March 24, 2025 16:36
edoversb
edoversb approved these changes Mar 24, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@edoversb edoversb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edoversb edoversb merged commit 32e525c into main Mar 24, 2025
5 of 6 checks passed
@edoversb edoversb deleted the nick/floating-comments2 branch March 24, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edoversb edoversb edoversb approved these changes

Assignees

@harbournick harbournick

Labels

ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@harbournick @edoversb