Skip to content

HAR-9211 Comments export fixes#414

Merged
harbournick merged 1 commit intomainfrom
har-9211_comments-export
Mar 24, 2025
Merged

HAR-9211 Comments export fixes#414
harbournick merged 1 commit intomainfrom
har-9211_comments-export

Conversation

@VladaHarbour
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread packages/super-editor/src/core/super-converter/SuperConverter.js
name: 'w:br',
type: 'element',
attributes: { 'w:type': 'page' }
name: 'w:r',
Copy link
Copy Markdown
Contributor Author

@VladaHarbour VladaHarbour Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harbournick When Word recovers our documents it wraps hard breaks into run for some reason

let commentSchema = getCommentSchema(type, commentIndex);
if (type === 'End') {
const commentReference = { name: 'w:commentReference', attributes: { 'w:id': String(commentIndex) } };
const commentReference = {
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harbournick Same with wrapping here

"attributes": {
"w16cex:durableId": newDurableId,
"w16cex:dateUtc": "2025-03-06T23:32:00Z"
"w16cex:dateUtc": toIsoNoFractional()
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure it has to be hardcoded

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah, that was my mistake. thanks for fixing!

Copy link
Copy Markdown
Collaborator

@harbournick harbournick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harbournick harbournick merged commit 568f85c into main Mar 24, 2025
6 checks passed
@harbournick harbournick deleted the har-9211_comments-export branch March 24, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants