Skip to content

HAR-8799 Overflow menu state should remain selected while open #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harbournick merged 1 commit into from
Mar 26, 2025
Merged

HAR-8799 Overflow menu state should remain selected while open #426

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions packages/super-editor/src/components/toolbar/OverflowMenu.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<script setup>
import { getCurrentInstance, ref } from 'vue';
import { getCurrentInstance, ref, computed } from 'vue';
import ToolbarButton from './ToolbarButton.vue';
import ButtonGroup from './ButtonGroup.vue';

Expand All @@ -18,6 +18,11 @@ const props = defineProps({

const isDropdownOpened = ref(false);

const overflowToolbarItem = computed(() => ({
...props.toolbarItem,
active: isDropdownOpened,
}));

const toggleOverflowMenu = () => {
isDropdownOpened.value = !isDropdownOpened.value;
};
Expand All @@ -30,7 +35,10 @@ const handleCommand = ({ item, argument }) => {
<template>
<div class="overflow-menu">
<div class="overflow-menu-trigger">
<ToolbarButton :toolbar-item="toolbarItem" @buttonClick="toggleOverflowMenu" />
<ToolbarButton
:toolbar-item="overflowToolbarItem"
@buttonClick="toggleOverflowMenu"
/>
</div>
<div v-if="isDropdownOpened" class="overflow-menu_items">
<ButtonGroup :toolbar-items="overflowItems" @command="handleCommand" class="superdoc-toolbar-overflow" />
Expand Down