Merged
Conversation
Contributor
VladaHarbour
commented
Mar 28, 2025
VladaHarbour
commented
- Creates bullet list by typing '- '
- Creates ordered list by typing '1. + Enter'
Collaborator
|
@artem-harbour mind reviewing this one as well pls? |
| } | ||
| if (config.keepAttributes) { | ||
| /** If the nodeType is `bulletList` or `orderedList` set the `nodeType` as `listItem` */ | ||
| const nodeType = config.type.name === 'bulletList' || config.type.name === 'orderedList' ? 'listItem' : 'taskList'; |
Contributor
There was a problem hiding this comment.
We do not have taskList node type, please fix this.
| @@ -0,0 +1,32 @@ | |||
| export const undoInputRule = () => ({ state, dispatch }) => { | |||
Contributor
There was a problem hiding this comment.
I would prefer not do undoInputRule and keep it as simple as possible.
@harbournick, what do you think?
Contributor
Author
There was a problem hiding this comment.
When used with ordered list it’s more essential (from my point of view) to undo the rule on delete to leave the initial typing
If not the initial typing will be removed
artem-harbour
requested changes
Mar 31, 2025
Contributor
artem-harbour
left a comment
artem-harbour
left a comment
There was a problem hiding this comment.
Added my comments.
FYI @harbournick
harbournick
approved these changes
Apr 2, 2025
|
|
||
| const handleBackspace = () => | ||
| this.editor.commands.first(({ commands, tr }) => [ | ||
| () => commands.undoInputRule(), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.