HAR-9057 - getting super editor keydown event for enabling agreement link updates#433
Closed
mattConnHarbour wants to merge 1 commit intomainfrom
Closed
HAR-9057 - getting super editor keydown event for enabling agreement link updates#433mattConnHarbour wants to merge 1 commit intomainfrom
mattConnHarbour wants to merge 1 commit intomainfrom
Conversation
mattConnHarbour
commented
Mar 28, 2025
|
|
||
| const handleSuperEditorKeydown = (event) => { | ||
| emit('editor-keydown', { editor: editor.value }); | ||
| props.options.onKeydown({editor: editor.value }) |
Contributor
Author
There was a problem hiding this comment.
@harbournick Am I using this as intended? I was having issues just using an "emit" before.
Collaborator
There was a problem hiding this comment.
I would prefer to not add more hooks here that will complicate the API. Couldn't we just use the existing onUpdate hook?
harbournick
requested changes
Mar 28, 2025
|
|
||
| const handleSuperEditorKeydown = (event) => { | ||
| emit('editor-keydown', { editor: editor.value }); | ||
| props.options.onKeydown({editor: editor.value }) |
Collaborator
There was a problem hiding this comment.
I would prefer to not add more hooks here that will complicate the API. Couldn't we just use the existing onUpdate hook?
Collaborator
|
Closing this one after discussion. Based on the requirements, it seems that an existing hook like onUpdate will do the trick. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to Webapp PR: https://github.com/Harbour-Enterprises/Harbour-WebApp/pull/5890