HAR-9383 - create comments for imported tracked changes#436
Merged
harbournick merged 1 commit intomainfrom Mar 28, 2025
Merged
Conversation
artem-harbour
commented
Mar 28, 2025
| const getTrackedChangeText = ({ node, mark, trackedChangeType, isDeletionInsertion, deletionNodes = [] }) => { | ||
| const deletionText = deletionNodes.length ? deletionNodes[0].text : null; | ||
|
|
||
| let trackedChangeText = isDeletionInsertion ? nextNode.text : node.text; |
Contributor
Author
There was a problem hiding this comment.
@harbournick - Not sure what you wanted to do here, but nextNode variable was not defined.
artem-harbour
commented
Mar 28, 2025
| const node = nodes[0]; | ||
| const nextTrackedNode = null; // | ||
| const isDeletionInsertion = ( | ||
| trackedChangeType === TrackDeleteMarkName && nextTrackedNode?.type?.name === TrackInsertMarkName |
Contributor
Author
There was a problem hiding this comment.
nextTrackedNode variable was not defined too.
Collaborator
There was a problem hiding this comment.
Oh yeah, I'll remove some of this. This was left over from the previous iteration of this and prob not needed. I'll clean it up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.