HAR-9057 - superdoc event - bubbling up update event#440
Merged
harbournick merged 1 commit intomainfrom Apr 2, 2025
Merged
Conversation
harbournick
requested changes
Apr 1, 2025
Collaborator
harbournick
left a comment
harbournick
left a comment
There was a problem hiding this comment.
Just a small change
| this.on('pdf-document-ready', this.config.onPdfDocumentReady); | ||
| this.on('sidebar-toggle', this.config.onSidebarToggle); | ||
| this.on('collaboration-ready', this.config.onCollaborationReady); | ||
| this.on('update', this.config.onEditorUpdate); |
Collaborator
There was a problem hiding this comment.
I don't think the event here should just be 'update' because this specifically relates to editor updates. SuperDoc also handles multiple documents, comments... PDF documents, all of which can have 'update' events but that won't be relevant here. we should keep something like 'editor-update'
mattConnHarbour
force-pushed
the
HAR-9057_2
branch
from
fec31ac to
065148f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.