Skip to content

HAR-9405 - update rich text extensions#442

Merged
harbournick merged 1 commit intomainfrom
artem-HAR-9405
Apr 2, 2025
Merged

HAR-9405 - update rich text extensions#442
harbournick merged 1 commit intomainfrom
artem-HAR-9405

Conversation

@artem-harbour
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Collaborator

@harbournick harbournick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harbournick
Copy link
Copy Markdown
Collaborator

Actually its failing CICD - we'll need to fix that before merging this one. I had tried to do this previously and noticed CICD fails on Git but wasn't failing locally

import { join } from 'path';
import { readFile } from 'fs/promises';
import { Editor } from '@core/Editor.js';
import { getRichTextExtensions } from '@harbour-enterprises/super-editor';
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the issue.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahhh makes sense - thank you for finding!

@artem-harbour
Copy link
Copy Markdown
Contributor Author

Actually its failing CICD - we'll need to fix that before merging this one. I had tried to do this previously and noticed CICD fails on Git but wasn't failing locally

Fixed.

Copy link
Copy Markdown
Collaborator

@harbournick harbournick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harbournick harbournick merged commit 25b2b98 into main Apr 2, 2025
6 checks passed
@harbournick harbournick deleted the artem-HAR-9405 branch April 2, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants